-
-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type hints for scalar arguments and return values in Zend3 #1658
Add type hints for scalar arguments and return values in Zend3 #1658
Conversation
Discussion of the failed checks, and how to handle them properly, was started in #1656 before this WIP was submitted for reference. |
} | ||
|
||
if (file_exists('ext')) { | ||
exec('rm -rf ext/'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you adopt this to use in AppVeyor (Windows) too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. fair point. I'll need to take a peek at the other test I pulled this block from and adjust it, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is addressed. Now handling the other issues that are preventing this WIP from becoming a true PR.
a1b5337
to
d16348f
Compare
d16348f
to
98e8445
Compare
OK, should be ready to go. The most recent change was to start using the PHP version to detect whether we have support for strict typing or not, and adjusting the expected exception accordingly. With |
Thank you! |
Fixes #1656