Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2176 - Fix ZEND_FENTRY() for interface with static method without parameters #2178

Conversation

ufoproger
Copy link
Contributor

@ufoproger ufoproger commented Mar 29, 2021

Hello!

In raising this pull request, I confirm the following:

  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Small description of change:
Use arginfo when calling macros ZEND_FENTRY() for interface static method without parameters. Needs for PHP 8.

Thanks

P.S.: pull request #2177 can be deleted.

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #2178 (f47836b) into development (d89a471) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##             development   #2178      +/-   ##
================================================
- Coverage           7.69%   7.69%   -0.01%     
  Complexity          8688    8688              
================================================
  Files                355     355              
  Lines              21965   21973       +8     
================================================
  Hits                1690    1690              
- Misses             20275   20283       +8     

@ufoproger ufoproger changed the title Fix ZEND_FENTRY() for interface with static method without parameters Fix #2176 - ZEND_FENTRY() for interface with static method without parameters Mar 29, 2021
@ufoproger ufoproger changed the title Fix #2176 - ZEND_FENTRY() for interface with static method without parameters #2176 - Fix ZEND_FENTRY() for interface with static method without parameters Mar 29, 2021
@Jeckerson
Copy link
Member

Could you please add test case with .zep and update CHANGELOG.md?

@Jeckerson Jeckerson added this to the 0.13.x milestone Mar 29, 2021
@ufoproger
Copy link
Contributor Author

Done.

@Jeckerson Jeckerson modified the milestones: 0.13.x, 0.13.1 Mar 29, 2021
@AlexNDRmac AlexNDRmac merged commit c800ac0 into zephir-lang:development Mar 29, 2021
@ufoproger ufoproger deleted the php8-interface-static-method-wo-params branch March 29, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZEND_FENTRY() for interface with static method without parameters does not use arginfo (PHP8)
3 participants