Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#203 - Add support syntax passing variables by reference #2214

Merged
merged 2 commits into from
Apr 24, 2021
Merged

#203 - Add support syntax passing variables by reference #2214

merged 2 commits into from
Apr 24, 2021

Conversation

JellyBrick
Copy link
Contributor

@JellyBrick JellyBrick commented Apr 14, 2021 •
edited
Loading

Hello!

In raising this pull request, I confirm the following:

  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Small description of the change:

  • Add support for passing variables by reference

#609 (comment)

Thanks

@JellyBrick JellyBrick changed the title Implement 'passing variables by reference' #203 - Add support for passing variables by reference Apr 14, 2021
@codecov
Copy link

codecov bot commented Apr 14, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (feature/references@5433438). Click here to learn what that means.
The diff coverage is 0.00%.

❗ Current head 1781b55 differs from pull request most recent head cfcb9c0. Consider uploading reports for the commit cfcb9c0 to get more accurate results

@@                 Coverage Diff                  @@
##             feature/references   #2214   +/-   ##
====================================================
  Coverage                      ?   7.70%           
  Complexity                    ?    8680           
====================================================
  Files                         ?     355           
  Lines                         ?   21972           
  Branches                      ?       0           
====================================================
  Hits                          ?    1692           
  Misses                        ?   20280           
  Partials                      ?       0

@Jeckerson
Copy link
Member

Hello! Could you add some tests?

@JellyBrick JellyBrick changed the title #203 - Add support for passing variables by reference #203 - Add support syntax passing variables by reference Apr 14, 2021
@JellyBrick JellyBrick force-pushed the development branch 3 times, most recently from 890e9e5 to 4ae7901 Compare April 14, 2021 10:56
@Jeckerson Jeckerson added the nfr New Feature Request label Apr 14, 2021
@JellyBrick JellyBrick marked this pull request as draft April 16, 2021 08:06
@Jeckerson
Copy link
Member

@JellyBrick Hi, any news or ETA on that?

@JellyBrick
Copy link
Contributor Author

JellyBrick commented Apr 18, 2021 •
edited
Loading

TODO

  • Add support syntax typed reference (like int&)

@Jeckerson
Copy link
Member

@JellyBrick Could you implement that or prefer to pass for us?

@JellyBrick
Copy link
Contributor Author

@Jeckerson

prefer to pass for us?

👌

@JellyBrick JellyBrick marked this pull request as ready for review April 18, 2021 08:49
@JellyBrick JellyBrick force-pushed the development branch 2 times, most recently from 9f80e62 to 741b0df Compare April 18, 2021 10:27
JellyBrick added a commit to organization/zephir that referenced this pull request Apr 18, 2021
@JellyBrick
zephir-lang#2214 - Implement 'passing variables by reference'
bed4bae
@JellyBrick JellyBrick force-pushed the development branch 2 times, most recently from bed4bae to e423773 Compare April 18, 2021 14:02
@JellyBrick
Copy link
Contributor Author

@Jeckerson Should I add a test for typed reference?

@Jeckerson
Copy link
Member

@JellyBrick Yes please. Also, as this PR is not implements full support of references, I'll create new separate branch references and this PR will be merged there. To make it easy to track process of this feature, because we still need to decide if it will be in v0.13.x or in v0.14.x.

@Jeckerson Jeckerson changed the base branch from development to feature/references April 19, 2021 13:30
@Jeckerson Jeckerson merged commit b9242c5 into zephir-lang:feature/references Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees
No one assigned
Labels
nfr New Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JellyBrick @Jeckerson