#1259 - Fix unset from class property

[Jeckerson]

Hello!

• Type: bug fix

In raising this pull request, I confirm the following:

• I have checked that another pull request for this purpose does not exist
• I wrote some tests for this PR
• I updated the CHANGELOG

Small description of change:

#define SEPARATE_ZVAL(zv) do {                            
        zval *_zv = (zv);                                
        if (Z_ISREF_P(_zv)) {                            
            zend_reference *_r = Z_REF_P(_zv);            
            ZVAL_COPY_VALUE(_zv, &_r->val);                
            if (GC_DELREF(_r) == 0) {                    
                efree_size(_r, sizeof(zend_reference));    
            } else if (Z_OPT_TYPE_P(_zv) == IS_ARRAY) {    
                ZVAL_ARR(_zv, zend_array_dup(Z_ARR_P(_zv)));
                break;                                    
            } else if (Z_OPT_REFCOUNTED_P(_zv)) {        
                Z_ADDREF_P(_zv);                        
                break;                                    
            }                                            
        }                                                
        if (Z_TYPE_P(_zv) == IS_ARRAY) {                
            SEPARATE_ARRAY(_zv);                        
        }                                                
    } while (0)

Thanks

[Jeckerson]

Need to be implemented with zephir_unset_property_array().

[Jeckerson]

zval tmp;
ZVAL_NEW_STR(&tmp, "key_a");
zephir_unset_property_array(this_ptr, ZEND_STRL("unsetData"), &tmp);

[codecov]

Codecov Report

Merging #2222 (cb7a9fc) into development (7dda56b) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##             development   #2222      +/-   ##
================================================
- Coverage           7.68%   7.68%   -0.01%     
- Complexity          8696    8700       +4     
================================================
  Files                355     355              
  Lines              22031   22053      +22     
================================================
  Hits                1694    1694              
- Misses             20337   20359      +22