-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts: ci: check_compliance strips required information #68037
Comments
@carlescufi that was you adding this, can you please take a look? |
This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time. |
Switch from plain text to JSON output in the pyling compliance check in order to handle multi-line messages, which were so far being dropped by the regex. Fixes zephyrproject-rtos#68037. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
Switch from plain text to JSON output in the pylint compliance check in order to handle multi-line messages, which were so far being dropped by the regex. Fixes zephyrproject-rtos#68037. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
Switch from plain text to JSON output in the pylint compliance check in order to handle multi-line messages, which were so far being dropped by the regex. Fixes #68037. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
Switch from plain text to JSON output in the pylint compliance check in order to handle multi-line messages, which were so far being dropped by the regex. Fixes zephyrproject-rtos#68037. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
Switch from plain text to JSON output in the pylint compliance check in order to handle multi-line messages, which were so far being dropped by the regex. Fixes zephyrproject-rtos#68037. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
Describe the bug
The error parsing regex in
check_compliance.py
strips out information required to fix the problem forduplicate-code
warnings:zephyr/scripts/ci/check_compliance.py
Line 950 in 8a2a44f
Logs and console output
For code triggering the similarity checker,
check_compliance.py
outputs the following:and
compliance.xml
contains:Neither of which are helpful for determining which files have similar code, or where in the file that code is.
It actually points to the wrong location (line 1, instead of line 48).
Running the pylint command manually on the same failing code outputs:
The text was updated successfully, but these errors were encountered: