Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings_fcb: Fix storing the data #25518

Merged
merged 1 commit into from
May 21, 2020

Conversation

MarekPieta
Copy link
Collaborator

@MarekPieta MarekPieta commented May 21, 2020

Change fixes storing the data by adding missing write retry after the last compression. Without the change error was returned instead of retrying.

fixes #25522

Change fixes storing the data by adding missing write retry after
the last compression. Without the change error was returned instead
of retrying.

Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no>
@MarekPieta MarekPieta requested a review from nvlsianpu May 21, 2020 12:41
@zephyrbot zephyrbot added the area: Settings Settings subsystem label May 21, 2020
@nvlsianpu nvlsianpu added the bug The issue is a bug, or the PR is fixing a bug label May 21, 2020
@nvlsianpu
Copy link
Collaborator

I registered the bug you are fixing: #25522

@nvlsianpu nvlsianpu requested a review from carlescufi May 21, 2020 13:30
@nvlsianpu nvlsianpu added the priority: medium Medium impact/importance bug label May 21, 2020
@nvlsianpu nvlsianpu requested a review from pdunaj May 21, 2020 13:35
@nvlsianpu nvlsianpu added this to the v2.3.0 milestone May 21, 2020
@carlescufi carlescufi merged commit 775b245 into zephyrproject-rtos:master May 21, 2020
nvlsianpu added a commit to nvlsianpu/zephyr that referenced this pull request Jun 2, 2020
Change fixes storing the data by adding missing write retry after
the last compression. Without the change error was returned instead
of retrying.

This is manual back-port of zephyrproject-rtos#25518

Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no>
Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
nashif pushed a commit that referenced this pull request Jun 4, 2020
Change fixes storing the data by adding missing write retry after
the last compression. Without the change error was returned instead
of retrying.

This is manual back-port of #25518

Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no>
Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
nwsetec pushed a commit to nwsetec/zephyr that referenced this pull request Nov 2, 2020
Change fixes storing the data by adding missing write retry after
the last compression. Without the change error was returned instead
of retrying.

This is manual back-port of zephyrproject-rtos#25518

Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no>
Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
(cherry picked from commit 7c73965)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Settings Settings subsystem bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

settings: FCB back-end does not try to add record after the last compression attempt.
5 participants