-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
settings_fcb: Fix storing the data #25518
Merged
carlescufi
merged 1 commit into
zephyrproject-rtos:master
from
MarekPieta:settings_fcb_fix
May 21, 2020
Merged
settings_fcb: Fix storing the data #25518
carlescufi
merged 1 commit into
zephyrproject-rtos:master
from
MarekPieta:settings_fcb_fix
May 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change fixes storing the data by adding missing write retry after the last compression. Without the change error was returned instead of retrying. Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no>
nvlsianpu
approved these changes
May 21, 2020
I registered the bug you are fixing: #25522 |
pdunaj
approved these changes
May 21, 2020
carlescufi
approved these changes
May 21, 2020
nvlsianpu
added a commit
to nvlsianpu/zephyr
that referenced
this pull request
Jun 2, 2020
Change fixes storing the data by adding missing write retry after the last compression. Without the change error was returned instead of retrying. This is manual back-port of zephyrproject-rtos#25518 Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no> Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
nashif
pushed a commit
that referenced
this pull request
Jun 4, 2020
Change fixes storing the data by adding missing write retry after the last compression. Without the change error was returned instead of retrying. This is manual back-port of #25518 Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no> Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
nwsetec
pushed a commit
to nwsetec/zephyr
that referenced
this pull request
Nov 2, 2020
Change fixes storing the data by adding missing write retry after the last compression. Without the change error was returned instead of retrying. This is manual back-port of zephyrproject-rtos#25518 Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no> Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no> (cherry picked from commit 7c73965)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: Settings
Settings subsystem
bug
The issue is a bug, or the PR is fixing a bug
priority: medium
Medium impact/importance bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change fixes storing the data by adding missing write retry after the last compression. Without the change error was returned instead of retrying.
fixes #25522