boards: arm: bl654_usb: Fix USB enablement issues #39987
Conversation
This addresses USB issues with the BL654 USB dongle which prevent USB from working properly (e.g. hci_usb) or do not automatically give access to the console of the board (most other samples) by adding a feature that will automatically enable the USB peripheral on startup without needing to be manually added to sample/user applications. Signed-off-by: Jamie McCrae <jamie.mccrae@lairdconnect.com>
| @@ -26,7 +26,10 @@ config FLASH_LOAD_OFFSET | |||
| if USB_DEVICE_STACK | |||
|
|
|||
| config USB_UART_CONSOLE | |||
| default y | |||
| default y if !USB_DEVICE_BLUETOOTH | |||
There was a problem hiding this comment.
Changes in this file should be in own commit, which fixes #39904.
There was a problem hiding this comment.
@lairdjm could you please do that as suggested by @jfischer-no?
There was a problem hiding this comment.
@carlescufi this is awaiting a USB fix from @jfischer-no
There was a problem hiding this comment.
For completeness, option USB_UART_CONSOLE is removed, see #40428. Shield approach in #40220 was not accepted. I opened #40645 to continue the discussion.
Anyway, I do not want to accept any USB device support setting at board level anymore. The boards in Zephyr tree should be in minimal configuration, https://docs.zephyrproject.org/latest/guides/porting/board_porting.html#general-recommendations, so no configuration to enable USB support or USB device classes.
|
Apart from #39987 (comment), this patch is a selfish approach, which will also be a bad example for other boards. I am looking at how we can make it better and bring USB device support initialization during startup back in case only CDC ACM class is enabled and CDC ACM UART is used as logging/shell backend. |
|
@carlescufi can we progress with this temporary fix for the upcoming release until there is a proper global fix for this? As this basically means the bl654_usb board is dead without manual changes to customer codebases |
|
Fixed in #42371 |
This addresses USB issues with the BL654 USB dongle which prevent USB
from working properly (e.g. hci_usb) or do not automatically give
access to the console of the board (most other samples) by adding a
feature that will automatically enable the USB peripheral on startup
without needing to be manually added to sample/user applications.
Signed-off-by: Jamie McCrae jamie.mccrae@lairdconnect.com
Fixes #39904 and addresses #39969