dma: Update dma_dw from sof #43883
Merged
dma: Update dma_dw from sof #43883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teburd
force-pushed
the
dma_cavs_gpdma_sof
branch
6 times, most recently
from
bce8579
to
7164c6e
Compare
github-actions
bot
added
the
area: Tests
teburd
force-pushed
the
dma_cavs_gpdma_sof
branch
3 times, most recently
from
fbecd8c
to
69e2c1c
Compare
teburd
force-pushed
the
dma_cavs_gpdma_sof
branch
4 times, most recently
from
b9fd5b9
to
3b743ac
Compare
teburd
force-pushed
the
dma_cavs_gpdma_sof
branch
from
1bcf1e1
to
36fe6c4
Compare
teburd
force-pushed
the
dma_cavs_gpdma_sof
branch
6 times, most recently
from
6d4c204
to
852593b
Compare
|
@teburd can you please rebase? |
Adds a bit flag config option for cyclic transfer lists, where the transfer list tail may link to its head creating a never ending loop of transfer descriptors. DesignWare DMA supports such cyclic transfers. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
Adds to the dma_status struct the number of free bytes available in the current transfer buffer. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
teburd
force-pushed
the
dma_cavs_gpdma_sof
branch
2 times, most recently
from
b0a76cf
to
f4ed876
Compare
|
Tested in SOF by @abonislawski and with the new DAI drivers by @juimonen |
teburd
force-pushed
the
dma_cavs_gpdma_sof
branch
from
f4ed876
to
729a11d
Compare
nashif
previously approved these changes
Mar 28, 2022
dcpleung
previously approved these changes
Mar 28, 2022
teburd
force-pushed
the
dma_cavs_gpdma_sof
branch
from
729a11d
to
ae9bce7
Compare
dcpleung
previously approved these changes
Mar 28, 2022
nashif
previously approved these changes
Mar 28, 2022
teburd
force-pushed
the
dma_cavs_gpdma_sof
branch
2 times, most recently
from
3db501b
to
833134d
Compare
Ports the SOF DesignWare DMA code to Zephyr. Effectively replaces much of what was the designware driver as this driver enables scatter gather which the older driver did not. * Enables cyclic transfer description lists when the cyclic config param is given. * Enables linear link position usage with cAVS GPDMA. * Passes suspend/resume, scatter/gather tests. * Provides status updates of the transfer through dma_get_status() * Enables reloading a cyclic transfer with dma_reload() * Enables dma handshakes using the dma_slot config param. * cAVS specifics remain in the dma_cavs_gpdma driver. Co-authored-by: Adrian Bonislawski <adrian.bonislawski@intel.com> Co-authored-by: Tom Burdick <thomas.burdick@intel.com> Signed-off-by: Tom Burdick <thomas.burdick@intel.com>
nashif
approved these changes
Mar 29, 2022
Merged
dcpleung
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports the existing SOF DesignWare DMA code to Zephyr styling, calls, Kconfig setup and such.
Effectively replaces much of what was the designware driver as this
driver enables scatter gather which the older driver did not.
Passes newly updated suspend/resume and created scatter gather test cases. Works in SoF thanks to the great work from @abonislawski
Marked DNM until dependent PRs make their way in
I realize the commit sequence is maybe a little messy for some, but this was a collaborative effort and I don't wish to squash it all immediatelySigned-off-by: Tom Burdick thomas.burdick@intel.com