Update NET_BUF_POOL_FIXED_DEFINE: added the alignment for net_buf_data #48713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npal-cy
requested review from
jhedberg,
tbursztyka,
pfalcon and
rlubos
as code owners
jhedberg
previously approved these changes
Aug 5, 2022
NET_BUF_POOL_FIXED_DEFINE locates net_buf_data in __noinit section, it does not guarantees that data buffer will aligned. There is wifi driver which required network buffers to be aligned. Changes: line below (from NET_BUF_POOL_FIXED_DEFINE macro): static uint8_t __noinit net_buf_data_##_name[_count][_data_size]; is updated to: static uint8_t __noinit net_buf_data_##_name[_count][_data_size] __net_buf_align; Signed-off-by: Nazar Palamar <nazar.palamar@infineon.com>
npal-cy
force-pushed
the
topic/update_NET_BUF_POOL_FIXED_DEFINE
branch
from
75229ca
to
dafe8a4
Compare
Thanks! fixed. |
rlubos
approved these changes
Aug 5, 2022
jukkar
approved these changes
Aug 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include/net: add the alignment for data in NET_BUF_POOL_FIXED_DEFINE
NET_BUF_POOL_FIXED_DEFINE locates net_buf_data in __noinit section,
it does not guarantees that data buffer will aligned.
There is wifi driver which required network buffers to be aligned.
Changes:
line below (from NET_BUF_POOL_FIXED_DEFINE macro):
static uint8_t __noinit net_buf_data_##_name[_count][_data_size];is updated to:
static uint8_t __noinit net_buf_data_##_name[_count][_data_size] __net_buf_align;Signed-off-by: Nazar Palamar nazar.palamar@infineon.com
Some background for this update in discord: https://discord.com/channels/720317445772017664/733037635194585148/1004652532716552273