Bluetooth: Mesh: Rename adv relay to adv simultaneous #48903
Conversation
Since notice that simult advertising is not only used by relay message, provision over pb-adv can also be used. so it was changed to a more general name. Signed-off-by: Lingao Meng <menglingao@xiaomi.com>
LingaoM
force-pushed
the
rename_adv_relay
branch
from
a292649
to
6286cb9
Compare
LingaoM
changed the title
LingaoM
force-pushed
the
rename_adv_relay
branch
3 times, most recently
from
8c03d31
to
13925f8
Compare
Add config for pb-adv retransmit Signed-off-by: Lingao Meng <menglingao@xiaomi.com>
LingaoM
force-pushed
the
rename_adv_relay
branch
from
13925f8
to
cf27aa9
Compare
| @@ -245,7 +245,7 @@ static struct net_buf *adv_buf_create(uint8_t retransmits) | |||
| { | |||
| struct net_buf *buf; | |||
|
|
|||
| buf = bt_mesh_adv_create(BT_MESH_ADV_PROV, BT_MESH_LOCAL_ADV, | |||
| buf = bt_mesh_adv_create(BT_MESH_ADV_PROV, BT_MESH_SIMUL_ADV, | |||
There was a problem hiding this comment.
Could you elaborate on this change? What does it improve or fix? Also, what if CONFIG_BT_MESH_SIMULT_ADV_SETS > 1?
There was a problem hiding this comment.
Yep, the same question from me.
There was a problem hiding this comment.
you can try for this
There was a problem hiding this comment.
There was a problem hiding this comment.
I'm upload ellisys capture for this change, please take a look.
There was a problem hiding this comment.
With such configuration, would it make more sense to stop advertising if an ack is received? Then only one adv set is needed.
There was a problem hiding this comment.
That true, but actually we need at least two advertisers sets, since ack pdu not ack by peer.
There was a problem hiding this comment.
I think the idea is cool, but stopping the advertiser would be preferable as it will not generate so much traffic. I may guess the drawback of using 1 adv set is that and advertisement may already be scheduled by the time stop is called thus delaying the next message, but this I think will be an issue anyway even if multiple sets are used.
There was a problem hiding this comment.
Hm... How about the scenario with high-density traffic? Won't compete relayed traffic and provisioning for the same source? How about the reliability of the provisioning process? Seems that even if the provisioner isn't targeted for any model communication it becomes less responsible as a provisioner due to high-density traffic.
There was a problem hiding this comment.
The balance between high throughput and performance needs to be determined by the user.
| @@ -52,13 +52,41 @@ config BT_MESH_UNPROV_BEACON_INT | |||
| This option specifies the interval (in seconds) at which the | |||
| device sends unprovisioned beacon. | |||
|
|
|||
| if BT_MESH_PB_ADV | |||
There was a problem hiding this comment.
Would it make sense to hide PB-ADV parameters under menuconfig?
There was a problem hiding this comment.
Since this parameters only valid for PB-ADV.
| int "Provision pdu retransmit count" | ||
| default 0 | ||
| range 0 7 | ||
| help | ||
| Controls the number of retransmissions of original transaction pdu, |
There was a problem hiding this comment.
Suggestion to add "Link Open" to the description:
| int "Provision pdu retransmit count" | |
| default 0 | |
| range 0 7 | |
| help | |
| Controls the number of retransmissions of original transaction pdu, | |
| int "Link Open and Transaction PDU retransmit count" | |
| default 0 | |
| range 0 7 | |
| help | |
| Controls the number of retransmissions of original Link Open and Transaction PDU, |
| int "Provision transaction ack retransmit count" | ||
| default 2 | ||
| range 0 7 | ||
| help | ||
| Controls the number of retransmissions of original transaction ack, |
There was a problem hiding this comment.
Suggestion to add "Link Ack" to the description:
| int "Provision transaction ack retransmit count" | |
| default 2 | |
| range 0 7 | |
| help | |
| Controls the number of retransmissions of original transaction ack, | |
| int "Link Ack and Transaction Ack retransmit count" | |
| default 2 | |
| range 0 7 | |
| help | |
| Controls the number of retransmissions of original Link Open and Transaction Acknowledgment PDU, |
| config BT_MESH_SIMULT_ADV_SETS | ||
| int "Maximum of simultaneous message support" |
There was a problem hiding this comment.
Suggestion.
| config BT_MESH_SIMULT_ADV_SETS | |
| int "Maximum of simultaneous message support" | |
| config BT_MESH_MULTI_ADV_SETS | |
| int "Maximum number of parallel advertising sets that can be used by the Bluetooth Mesh stack" |
There was a problem hiding this comment.
As discussed here #48903 (comment) this approach generates a lot of unnecessary traffic. Probably, the correct way would be to find how to stop provisioning PDU advertisements.
|
@LingaoM are you planning to do anything with this PR? |
Since notice that simultaneous advertising is not only used
by relay message, provision over pb-adv can also be used.
so it was changed to a more general name.
Signed-off-by: Lingao Meng menglingao@xiaomi.com