include: dt-bindings: pinctrl: stm32f1-afio: fix can & eth pinmap #49765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bindings for the stm32f105 afio pin remap had defined the wrong offset for CAN and ETH. This commit corrects those to the bits specified in RM0008 Rev.21, but the changes could not be verfied on hw. Signed-off-by: Thomas Stranger <thomas.stranger@outlook.com>
str4t0m
requested review from
nashif,
carlescufi,
galak and
MaureenHelm
as code owners
str4t0m
added
bug
FRASTM
approved these changes
Sep 1, 2022
erwango
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bindings for the stm32f105 afio pin remap had defined the wrong offset for CAN and ETH.
This commit corrects those to the bits specified in RM0008 Rev.21, section 9.4.2.
Note that I don't have the hardware to verify the change.
Fixes #49805