samples: Bluetooth: Demonstrate MTU update #53593
Conversation
theob-pro
force-pushed
the
large-mtu-sample
branch
18 times, most recently
from
c497d86
to
d95abf7
Compare
theob-pro
requested review from
nashif,
alwa-nordic,
jhedberg,
Vudentz,
wopu-ot and
sjanc
as code owners
zephyrbot
requested review from
asbjornsabo,
hermabe,
jori-nordic and
Thalley
theob-pro
force-pushed
the
large-mtu-sample
branch
from
c447a01
to
5b841fe
Compare
Add a new sample that demonstrate how to exchange MTU to allow larger packet transmission. The sample is split in two applications. One is the Central, it will initiate the MTU exchange. The other one is the Peripheral and will try to send a large notification. If the MTU exchange fail or the new size is not big enough, the Peripheral will not be able to send the notification. Signed-off-by: Théo Battrel <theo.battrel@nordicsemi.no>
Test that the Central receive the rigtht data from the Peripheral notification. Signed-off-by: Théo Battrel <theo.battrel@nordicsemi.no>
theob-pro
force-pushed
the
large-mtu-sample
branch
from
5b841fe
to
e6de2ed
Compare
theob-pro
force-pushed
the
large-mtu-sample
branch
2 times, most recently
from
0aa5e33
to
16a7a07
Compare
Update the README to add more informations on MTUs. Also add a diagram of the different MTU and Kconfig symbols in the Host. Signed-off-by: Théo Battrel <theo.battrel@nordicsemi.no>
theob-pro
force-pushed
the
large-mtu-sample
branch
from
16a7a07
to
0874288
Compare
|
I'm going over the Zephyr sample definition, and point 6 says that a sample should have minimal comments and not be explaining the WHY of something. But the sample currently has quite a bit of them, going into a lot the why and details of an MTU update. Would some of that be better served in a different part of the documentation instead of as part of a sample? |
| The first one should be flashed with the central and the second one with the | ||
| peripheral. | ||
|
|
||
| The two devices need to be close enough to be able to connect. |
There was a problem hiding this comment.
It's a bit hard to understand what is meant by this sentence. I think we should reword so it's clear it's a feature.
| The two devices need to be close enough to be able to connect. | |
| The two devices will connect only if they are close to each other, thanks to RSSI filtering. |
I think that the point 6 refer to code comment and not the README documentation. Anyway, I don't think that limiting the comment on code make a lot of sense either, is there a good reason for that? @carlescufi |
In this particular case the documentation included in the sample is definitely helpful and belongs in it. |
alwa-nordic
added
DNM
Update the Readme file of the large mtu sample because the orginal PR (zephyrproject-rtos#53593) has been merged before the last comment could be addressed. Signed-off-by: Théo Battrel <theo.battrel@nordicsemi.no>
Update the Readme file of the large mtu sample because the orginal PR (zephyrproject-rtos#53593) has been merged before the last comment could be addressed. Signed-off-by: Théo Battrel <theo.battrel@nordicsemi.no>
Update the Readme file of the large mtu sample because the orginal PR (#53593) has been merged before the last comment could be addressed. Signed-off-by: Théo Battrel <theo.battrel@nordicsemi.no>
Update the Readme file of the large mtu sample because the orginal PR (zephyrproject-rtos/zephyr#53593) has been merged before the last comment could be addressed. (cherry picked from commit 4314480) Original-Signed-off-by: Théo Battrel <theo.battrel@nordicsemi.no> GitOrigin-RevId: 4314480 Change-Id: I858888d9999864a7d7c9a739707c6136deff185a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/4173730 Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Tested-by: Fabio Baltieri <fabiobaltieri@google.com> Tested-by: CopyBot Service Account <copybot.service@gmail.com> Commit-Queue: Fabio Baltieri <fabiobaltieri@google.com>
Add a new sample and a BabbleSim test for it. The goal of this sample is to demonstrate how to update the MTU to allow larger packet transmission as requested by #25648.