MEC172x qmspi ldma fix spi nor support #55129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottwcpg
requested review from
tbursztyka,
nashif,
galak,
albertofloyd and
MaureenHelm
as code owners
zephyrbot
added
area: Devicetree Binding
scottwcpg
force-pushed
the
mec172x_qmspi_ldma_fix_spi_nor2
branch
2 times, most recently
from
7b8577d
to
18e67f3
Compare
galak
reviewed
Feb 23, 2023
|
@galak The sample app uses the shared SPI interface pins and mec172xmodular_assy6930 also uses the same pins. No change to application overlay. The app erases/writes/reads at SPI flash offset 0xC10000. If you have 16MByte flash on the board no problem. The address will wrap on smaller flashes and should work but the actual SPI address will depend upon the SPI flash size. |
scottwcpg
force-pushed
the
mec172x_qmspi_ldma_fix_spi_nor2
branch
from
18e67f3
to
b6fb955
Compare
|
@jvasanth1 @albertofloyd can you take a look please? |
jvasanth1
previously approved these changes
Mar 9, 2023
albertofloyd
previously approved these changes
Mar 14, 2023
|
@scottwcpg please rebase |
scottwcpg
force-pushed
the
mec172x_qmspi_ldma_fix_spi_nor2
branch
2 times, most recently
from
b3aaca0
to
ab1b3ee
Compare
|
Hi @carlescufi Rebased fixing YAML formatting, etc. |
jvasanth1
previously approved these changes
Mar 20, 2023
|
@albertofloyd can you help to re-approve? |
nashif
previously approved these changes
Mar 23, 2023
|
we have new conflicts, another rebase please. |
scottwcpg
force-pushed
the
mec172x_qmspi_ldma_fix_spi_nor2
branch
from
ab1b3ee
to
7e4a457
Compare
nashif
previously approved these changes
Mar 23, 2023
|
@nashif Twister failure is on beagleconnect_freedom board. Beagleconnect_freedom twister spif_flash fails in main branch where this MCHP PR does not exist. |
Zephyr SPI driver model for full-duplex operation assumes data will be transmitted and received during each clock period. The QMSPI driver for the XEC family also supported dual and quad I/O use cases which are inherently half-duplex. To support dual/quad the driver incorrectly processed spi buffers as all transmit buffers first then all receive buffers. This worked if only the SPI driver was used. It did not work with the Zephyr flash SPI NOR driver which assumes SPI drivers follow the SPI driver model. This commit implements a QMSPI driver that follows the Zephyr SPI driver model resulting in a slightly smaller driver. Dual/quad SPI transactions are supported if the experimental SPI extended mode Zephyr configuration flag is enabled. We also remove the QMSPI full duplex driver added previously to support the flash SPI NOR driver. Added board to spi loop-back test and spi_flash sample. Signed-off-by: Scott Worley <scott.worley@microchip.com>
Sample code for demonstrating spi buffer usage for single, dual, and quad SPI transfers. Signed-off-by: Scott Worley <scott.worley@microchip.com>
scottwcpg
force-pushed
the
mec172x_qmspi_ldma_fix_spi_nor2
branch
from
7e4a457
to
4a4ecd4
Compare
albertofloyd
approved these changes
Apr 4, 2023
|
@jvasanth1 please take a look |
jvasanth1
approved these changes
Apr 11, 2023
keith-zephyr
added a commit
to keith-zephyr/zephyr
that referenced
this pull request
Apr 17, 2023
PR zephyrproject-rtos#55129 deleted the "port-sel" property. Delete this property from the MEC1727nsz variant. Signed-off-by: Keith Short <keithshort@google.com>
keith-zephyr
added a commit
to keith-zephyr/zephyr
that referenced
this pull request
Apr 17, 2023
PR zephyrproject-rtos#55129 deleted the "port-sel" property. Delete this property from remaining Microchip SoC variants and boards. Test: west build -b mec172xevb_assy6906 samples/drivers/espi/ Signed-off-by: Keith Short <keithshort@google.com>
coreboot-org-bot
pushed a commit
to coreboot/zephyr-cros
that referenced
this pull request
Apr 17, 2023
PR zephyrproject-rtos/zephyr#55129 deleted the "port-sel" property. Delete this property from remaining Microchip SoC variants and boards. Test: west build -b mec172xevb_assy6906 samples/drivers/espi/ Cherry-picked from zephyrproject-rtos/zephyr#56949 BRANCH=none BUG=b:278560668 TEST=zmake build mtlrvpp_mchp Cq-Depend: chromium:4431679 Change-Id: I36d83b453aea765d842055e53f5d8c634fa3efe6 Signed-off-by: Keith Short <keithshort@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/4434469 Tested-by: Keith Short <keithshort@chromium.org> Reviewed-by: Al Semjonovs <asemjonovs@google.com> Reviewed-by: Aaron Massey <aaronmassey@google.com> Commit-Queue: Keith Short <keithshort@chromium.org>
carlescufi
pushed a commit
that referenced
this pull request
Apr 18, 2023
PR #55129 deleted the "port-sel" property. Delete this property from remaining Microchip SoC variants and boards. Test: west build -b mec172xevb_assy6906 samples/drivers/espi/ Signed-off-by: Keith Short <keithshort@google.com>
mkasenberg
pushed a commit
to mkasenberg/zephyr
that referenced
this pull request
Apr 19, 2023
PR zephyrproject-rtos#55129 deleted the "port-sel" property. Delete this property from remaining Microchip SoC variants and boards. Test: west build -b mec172xevb_assy6906 samples/drivers/espi/ Signed-off-by: Keith Short <keithshort@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Microchip MEC172x QMSPI-LDMA driver to work with Zephyr's SPI NOR flash driver. This PR provides multiple benefits: removal the QMSPI full duplex driver whose only purpose was compatibility with the SPI NOR flash driver, QMSPI-LDMA driver is added to the SPI loopback test and SPI flash sample, and support for Zephyr SPI extended modes for dual and quad. Only minor changes to applications are required to setup the SPI buffers similar to all other SPI drivers. The PR has two commits: first is the driver change and added MEC172x EVB support to the loopback test and SPI flash sample, the second is a custom board specific sample application demonstrating erase, program, and read (single, dual, quad).