spi: sam: Fix gpio chip select usage #57130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: SPI
pdgendt
reviewed
Apr 21, 2023
drivers/spi/spi_sam.c
Outdated
| @@ -128,7 +128,11 @@ static int spi_sam_configure(const struct device *dev, | |||
| * select mode. | |||
| */ | |||
| spi_mr |= (SPI_MR_MSTR | SPI_MR_MODFDIS); | |||
| spi_mr |= SPI_MR_PCS(spi_slave_to_mr_pcs(config->slave)); | |||
| if (config->cs) { | |||
There was a problem hiding this comment.
Maybe use a ternary operator?
yperess
previously approved these changes
Apr 21, 2023
nandojve
requested changes
Apr 23, 2023
yperess
added a commit
to yperess/zephyr
that referenced
this pull request
Apr 27, 2023
Once zephyrproject-rtos#57130 merges this will not be needed. Signed-off-by: Yuval Peress <peress@google.com>
yperess
added a commit
to yperess/zephyr
that referenced
this pull request
Apr 27, 2023
Once zephyrproject-rtos#57130 merges this will not be needed. Signed-off-by: Yuval Peress <peress@google.com>
yperess
added a commit
to yperess/zephyr
that referenced
this pull request
Apr 27, 2023
Once zephyrproject-rtos#57130 merges this will not be needed. Signed-off-by: Yuval Peress <peress@google.com>
yperess
added a commit
to yperess/zephyr
that referenced
this pull request
Apr 27, 2023
Once zephyrproject-rtos#57130 merges this will not be needed. Signed-off-by: Yuval Peress <peress@google.com>
yperess
added a commit
to yperess/zephyr
that referenced
this pull request
Apr 28, 2023
Once zephyrproject-rtos#57130 merges this will not be needed. Signed-off-by: Yuval Peress <peress@google.com>
pdgendt
reviewed
Apr 28, 2023
drivers/spi/spi_sam.c
Outdated
Comment on lines
131
to
135
| if (spi_cs_is_gpio(config)) { | ||
| spi_mr |= SPI_MR_PCS(spi_slave_to_mr_pcs(0)); | ||
| } else { | ||
| spi_mr |= SPI_MR_PCS(spi_slave_to_mr_pcs(config->slave)); | ||
| } |
There was a problem hiding this comment.
I still fail to understand why it wouldn't work without this change, but in any case you can shorten the statement:
Suggested change
| if (spi_cs_is_gpio(config)) { | |
| spi_mr |= SPI_MR_PCS(spi_slave_to_mr_pcs(0)); | |
| } else { | |
| spi_mr |= SPI_MR_PCS(spi_slave_to_mr_pcs(config->slave)); | |
| } | |
| spi_mr |= SPI_MR_PCS(spi_slave_to_mr_pcs(spi_cs_is_gpio(config) ? 0 : config->slave)); |
Same for the CSR.
EDIT: I guess the explanation here makes sense
nandojve
requested changes
Apr 28, 2023
When using gpio chip select the clock line seems to get stuck low after some transactions. When attempting to use other SPI_CSR registers the peripheral fails to work as expected. Always using SPI_CSR[0] when using gpio chip selects resolves the issue. Signed-off-by: Tom Burdick <thomas.burdick@intel.com>
pdgendt
approved these changes
Apr 28, 2023
yperess
approved these changes
Apr 28, 2023
nandojve
approved these changes
Apr 28, 2023
yperess
added a commit
to yperess/zephyr
that referenced
this pull request
May 1, 2023
Once zephyrproject-rtos#57130 merges this will not be needed. Signed-off-by: Yuval Peress <peress@google.com>
yperess
added a commit
to yperess/zephyr
that referenced
this pull request
May 1, 2023
Once zephyrproject-rtos#57130 merges this will not be needed. Signed-off-by: Yuval Peress <peress@google.com>
yperess
added a commit
to yperess/zephyr
that referenced
this pull request
May 4, 2023
Once zephyrproject-rtos#57130 merges this will not be needed. Signed-off-by: Yuval Peress <peress@google.com>
yperess
added a commit
to yperess/zephyr
that referenced
this pull request
May 4, 2023
Once zephyrproject-rtos#57130 merges this will not be needed. Signed-off-by: Yuval Peress <peress@google.com>
yperess
added a commit
to yperess/zephyr
that referenced
this pull request
May 11, 2023
Once zephyrproject-rtos#57130 merges this will not be needed. Signed-off-by: Yuval Peress <peress@google.com>
yperess
added a commit
to yperess/zephyr
that referenced
this pull request
May 12, 2023
Once zephyrproject-rtos#57130 merges this will not be needed. Signed-off-by: Yuval Peress <peress@google.com>
yperess
added a commit
to yperess/zephyr
that referenced
this pull request
May 12, 2023
Once zephyrproject-rtos#57130 merges this will not be needed. Signed-off-by: Yuval Peress <peress@google.com>
yperess
added a commit
to yperess/zephyr
that referenced
this pull request
May 12, 2023
Once zephyrproject-rtos#57130 merges this will not be needed. Signed-off-by: Yuval Peress <peress@google.com>
yperess
added a commit
to yperess/zephyr
that referenced
this pull request
May 15, 2023
Once zephyrproject-rtos#57130 merges this will not be needed. Signed-off-by: Yuval Peress <peress@google.com>
yperess
added a commit
to yperess/zephyr
that referenced
this pull request
May 15, 2023
Once zephyrproject-rtos#57130 merges this will not be needed. Signed-off-by: Yuval Peress <peress@google.com>
yperess
added a commit
to yperess/zephyr
that referenced
this pull request
May 15, 2023
Once zephyrproject-rtos#57130 merges this will not be needed. Signed-off-by: Yuval Peress <peress@google.com>
yperess
added a commit
to yperess/zephyr
that referenced
this pull request
May 16, 2023
Once zephyrproject-rtos#57130 merges this will not be needed. Signed-off-by: Yuval Peress <peress@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using gpio chip select the clock line seems to get stuck low after some transactions. When attempting to use other SPI_CSR registers the peripheral fails to work as expected.
Always using SPI_CSR[0] when using gpio chip selects resolves the issue.