Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers: dma: intel_adsp_hda: Fix L1 exit condition #69480

Merged
merged 1 commit into from
Mar 15, 2024
Merged

drivers: dma: intel_adsp_hda: Fix L1 exit condition #69480

merged 1 commit into from
Mar 15, 2024

Conversation

serhiy-katsyuba-intel
Copy link
Collaborator

Transition to a low power DMI L1 state should be allowed only after all pending DMA channels transfers have started.

@zephyrbot zephyrbot added platform: Intel ADSP Intel Audio platforms area: DMA Direct Memory Access labels Feb 26, 2024
@marc-hb
Copy link
Collaborator

marc-hb commented Feb 26, 2024

Please submit this to SOF CI using a draft PR. Like this: thesofproject/sof#8819

serhiy-katsyuba-intel added a commit to serhiy-katsyuba-intel/sof that referenced this pull request Feb 27, 2024
@serhiy-katsyuba-intel
[TEST][DNM] Test Zephyr PR 69480
80ce7c4 
DO NOT MERGE! CI RUN ONLY.

Tests "Fix L1 exit condiotion" Zephyr PR
zephyrproject-rtos/zephyr#69480

Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
@serhiy-katsyuba-intel serhiy-katsyuba-intel mentioned this pull request Feb 27, 2024
Closed
@lyakh
Copy link
Collaborator

lyakh commented Feb 28, 2024

Please submit this to SOF CI using a draft PR. Like this: thesofproject/sof#8819

@marc-hb this has also been tested (in a slightly different but verifiably equivalent form) by thesofproject/sof#8732

@lyakh lyakh mentioned this pull request Feb 28, 2024
Closed
tmleman
tmleman previously approved these changes Feb 29, 2024
View reviewed changes
@teburd
Copy link
Collaborator

teburd commented Feb 29, 2024

It seems like we've had a number of patches in this area now and none of them were entirely sufficient. It would really be great to see a test case covering this stuff to build some confidence and avoid regressions.

teburd
teburd previously approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@teburd teburd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but truly a test case covering this L1 exit path would be greatly appreciated. This must be the 3rd or 4th patch I've seen around this area.

@marc-hb
Copy link
Collaborator

marc-hb commented Feb 29, 2024

BTW I asked in #66042 (comment) why MTL and LNL are configured differently but I didn't see an answer.

abonislawski
abonislawski previously approved these changes Feb 29, 2024
View reviewed changes
@aescolar aescolar added the hwmv2-likely-conflict DNM until collab-hwmv2 has been merged label Mar 1, 2024
nordicjm
nordicjm previously requested changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs converting to hwmv2

@nordicjm nordicjm removed the hwmv2-likely-conflict DNM until collab-hwmv2 has been merged label Mar 4, 2024
lyakh
lyakh previously requested changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@lyakh lyakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to drop this patch from #69547 to make Chain DMA and probe quickbuild tests pass. With this commit in the set I was getting zero buffer size readings from the controller, which led to easily reproducible test failures

serhiy-katsyuba-intel added a commit to serhiy-katsyuba-intel/sof that referenced this pull request Mar 5, 2024
@serhiy-katsyuba-intel
[TEST][DNM] Test Zephyr PR 69480
f85314f 
DO NOT MERGE! CI RUN ONLY.

Tests "Fix L1 exit condiotion" Zephyr PR
zephyrproject-rtos/zephyr#69480

Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
@kv2019i kv2019i mentioned this pull request Mar 6, 2024
Closed
serhiy-katsyuba-intel added a commit to serhiy-katsyuba-intel/sof that referenced this pull request Mar 6, 2024
@serhiy-katsyuba-intel
[TEST][DNM] Test Zephyr L1 exit fix
1b4ebf8 
*** DO NOT MERGE! CI RUN ONLY! ***

Tests "Fix L1 exit condiotion" Zephyr PR zephyrproject-rtos/zephyr#69480

Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
@serhiy-katsyuba-intel serhiy-katsyuba-intel mentioned this pull request Mar 6, 2024
Closed
serhiy-katsyuba-intel added a commit to serhiy-katsyuba-intel/sof that referenced this pull request Mar 6, 2024
@serhiy-katsyuba-intel
[TEST][DNM] Test Zephyr L1 exit fix
3cbadb7 
*** DO NOT MERGE! CI RUN ONLY! ***

Tests "Fix L1 exit condiotion" Zephyr PR zephyrproject-rtos/zephyr#69480

Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
serhiy-katsyuba-intel added a commit to serhiy-katsyuba-intel/sof that referenced this pull request Mar 6, 2024
@serhiy-katsyuba-intel
[TEST][DNM] Test Zephyr L1 exit fix
f07f6ce 
*** DO NOT MERGE! CI RUN ONLY! ***

Tests "Fix L1 exit condiotion" Zephyr PR zephyrproject-rtos/zephyr#69480

Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
serhiy-katsyuba-intel added a commit to serhiy-katsyuba-intel/sof that referenced this pull request Mar 6, 2024
@serhiy-katsyuba-intel
[TEST][DNM] Test Zephyr L1 exit fix
49049f2 
*** DO NOT MERGE! CI RUN ONLY! ***

Tests "Fix L1 exit condiotion" Zephyr PR zephyrproject-rtos/zephyr#69480

Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
@kv2019i kv2019i mentioned this pull request Mar 11, 2024
Closed
@serhiy-katsyuba-intel
drivers: dma: intel_adsp_hda: Fix L1 exit condition
d9ce924 
Transition to a low power DMI L1 state should be allowed only after all
pending DMA channels transfers have started.

Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
@serhiy-katsyuba-intel
Copy link
Collaborator Author

@nordicjm , PR was rebased to main, so no problem with hwmv2 now.
@lyakh , the CI failure is not related to this PR but caused by a problem in SOF KPB. The fix is here: thesofproject/sof#8936

Could you guys approve/remove "change request" ?

@nordicjm nordicjm dismissed their stale review March 14, 2024 07:01

Addressed

serhiy-katsyuba-intel added a commit to serhiy-katsyuba-intel/sof that referenced this pull request Mar 14, 2024
@serhiy-katsyuba-intel
[DNM][CI RUN] Zephyr PR 69480 CI run
142dd3d 
*** DO NOT MERGE ***
*** CI RUN ONLY  ***

CI run for Zephyr L1 EXIT workaround
zephyrproject-rtos/zephyr#69480

Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
@serhiy-katsyuba-intel serhiy-katsyuba-intel mentioned this pull request Mar 14, 2024
Closed
@lyakh lyakh dismissed their stale review March 15, 2024 07:14

thesofproject/sof#8947 passed QB testing with this PR

@aescolar aescolar merged commit 41b3c71 into zephyrproject-rtos:main Mar 15, 2024
21 checks passed
@marc-hb marc-hb mentioned this pull request Jun 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kv2019i kv2019i kv2019i approved these changes

@plbossart plbossart plbossart approved these changes

@teburd teburd teburd approved these changes

@tmleman tmleman tmleman left review comments

@abonislawski abonislawski abonislawski left review comments

@nordicjm nordicjm nordicjm left review comments

@lyakh lyakh lyakh left review comments

@andyross andyross Awaiting requested review from andyross

@ceolin ceolin Awaiting requested review from ceolin

@dcpleung dcpleung Awaiting requested review from dcpleung

@jxstelter jxstelter Awaiting requested review from jxstelter

@lgirdwood lgirdwood Awaiting requested review from lgirdwood

@marc-hb marc-hb Awaiting requested review from marc-hb

@marcinszkudlinski marcinszkudlinski Awaiting requested review from marcinszkudlinski

@nashif nashif Awaiting requested review from nashif

@softwarecki softwarecki Awaiting requested review from softwarecki

Assignees

@teburd teburd

Labels
area: DMA Direct Memory Access platform: Intel ADSP Intel Audio platforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.