Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terminology: adopt CMake, python, and Kconfig code to use qualifiers #70438

Merged
merged 1 commit into from
Mar 21, 2024
Merged

terminology: adopt CMake, python, and Kconfig code to use qualifiers #70438

merged 1 commit into from
Mar 21, 2024

Conversation

tejlmand
Copy link
Collaborator

Followup: #69905

Adopting new board terminology for CMake, python, and Kconfig code to use qualifiers instead of identifiers.

Also adjusted to board target where applicable.

@tejlmand tejlmand mentioned this pull request Mar 19, 2024
Merged
@tejlmand tejlmand force-pushed the hwmv2_board_terminology_update branch from df9b4e7 to 800ccc1 Compare March 19, 2024 14:37
@tejlmand tejlmand force-pushed the hwmv2_board_terminology_update branch from 800ccc1 to 8c4f7cf Compare March 19, 2024 14:56
@zephyrbot zephyrbot added the area: West West utility label Mar 19, 2024
tejlmand added a commit to tejlmand/zephyr that referenced this pull request Mar 19, 2024
@tejlmand
terminology: adopt CMake, python, and Kconfig code to use qualifiers
02d3830 
DO NOT REVIEW.
Reviewed in zephyrproject-rtos#70438

Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
@nordicjm nordicjm mentioned this pull request Mar 20, 2024
Merged
tejlmand added a commit to tejlmand/zephyr that referenced this pull request Mar 21, 2024
@tejlmand
terminology: adopt CMake, python, and Kconfig code to use qualifiers
8b5fca7 
DO NOT REVIEW.
Reviewed in zephyrproject-rtos#70438

Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
gmarull
gmarull previously approved these changes Mar 21, 2024
View reviewed changes
nordicjm
nordicjm previously approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR with west boards completion needs to be merged right after this is merged

fabiobaltieri
fabiobaltieri previously approved these changes Mar 21, 2024
View reviewed changes
tejlmand added a commit to tejlmand/zephyr that referenced this pull request Mar 21, 2024
@tejlmand
terminology: adopt CMake, python, and Kconfig code to use qualifiers
4144858 
DO NOT REVIEW.
Reviewed in zephyrproject-rtos#70438

Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
@tejlmand
terminology: adopt CMake, python, and Kconfig code to use qualifiers
ad18ed2 
Followup: zephyrproject-rtos#69905

Adopting new board terminology for CMake, python, and Kconfig code to
use qualifiers instead of identifiers.

Also adjusted to board target where applicable.

Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
@tejlmand tejlmand dismissed stale reviews from fabiobaltieri, nordicjm, and gmarull via ad18ed2 March 21, 2024 13:16
@tejlmand tejlmand force-pushed the hwmv2_board_terminology_update branch from d266802 to ad18ed2 Compare March 21, 2024 13:16
@carlescufi carlescufi merged commit 732c504 into zephyrproject-rtos:main Mar 21, 2024
36 checks passed
aescolar added a commit to aescolar/zephyr that referenced this pull request Mar 21, 2024
@aescolar
tests|samples/bluetooth: Fix sysbuild due to BOAD_IDENTIFIER
c55c73a 
After zephyrproject-rtos#70438
got merged,
all these tests stopped building properly due to the
change of avaliable variables in Kconfig.
Let's fix them.
As a bonus, as the BOARD_TARGET_STRING is the same
for the hwmv1 backwards compatible name, let's
just remove the check for the old names.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
@aescolar aescolar mentioned this pull request Mar 21, 2024
Merged
aescolar added a commit to aescolar/zephyr that referenced this pull request Mar 21, 2024
@aescolar
tests|samples/bluetooth: Fix sysbuild due to BOAD_IDENTIFIER
58bf568 
After zephyrproject-rtos#70438
got merged simultaneously with
zephyrproject-rtos#70564
all these tests stopped building properly due to the
change of avaliable variables in Kconfig & cmake.
Let's fix them.
As a bonus, as for kconfig the BOARD_TARGET_STRING is the
same for the hwmv1 backwards compatible name, let's
just remove the check for the old names.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
@aescolar aescolar mentioned this pull request Mar 21, 2024
Closed
aescolar added a commit to aescolar/zephyr that referenced this pull request Mar 21, 2024
@aescolar
tests|samples/bluetooth: Fix sysbuild due to BOAD_IDENTIFIER
bfd0d1f 
After zephyrproject-rtos#70438
got merged simultaneously with
zephyrproject-rtos#70564
all these tests stopped building properly due to the
change of avaliable variables in Kconfig & cmake.
Let's fix them.
As a bonus, as for kconfig the BOARD_TARGET_STRING is the
same for the hwmv1 backwards compatible name, let's
just remove the check for the old names.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
aescolar added a commit that referenced this pull request Mar 21, 2024
@aescolar
tests|samples/bluetooth: Fix sysbuild due to BOAD_IDENTIFIER
f336026 
After #70438
got merged simultaneously with
#70564
all these tests stopped building properly due to the
change of avaliable variables in Kconfig & cmake.
Let's fix them.
As a bonus, as for kconfig the BOARD_TARGET_STRING is the
same for the hwmv1 backwards compatible name, let's
just remove the check for the old names.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
tejlmand added a commit to tejlmand/zephyr that referenced this pull request Mar 21, 2024
@tejlmand
sysbuild: update BOARD_IDENTIFIER to BOARD_QUALIFIERS
94c15d4 
Follow-up: zephyrproject-rtos#70438

Update BOARD_IDENTIFIER to BOARD_QUALIFIERS in Kconfig.sysbuild files.

Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
This was referenced Mar 21, 2024
Closed
Merged
selescop pushed a commit to selescop/zephyr that referenced this pull request Mar 22, 2024
@aescolar @selescop
tests|samples/bluetooth: Fix sysbuild due to BOAD_IDENTIFIER
d541b4b 
After zephyrproject-rtos#70438
got merged simultaneously with
zephyrproject-rtos#70564
all these tests stopped building properly due to the
change of avaliable variables in Kconfig & cmake.
Let's fix them.
As a bonus, as for kconfig the BOARD_TARGET_STRING is the
same for the hwmv1 backwards compatible name, let's
just remove the check for the old names.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
coreboot-org-bot pushed a commit to coreboot/zephyr-cros that referenced this pull request Mar 29, 2024
@aescolar
tests|samples/bluetooth: Fix sysbuild due to BOAD_IDENTIFIER
ae55106 
After zephyrproject-rtos/zephyr#70438
got merged simultaneously with
zephyrproject-rtos/zephyr#70564
all these tests stopped building properly due to the
change of avaliable variables in Kconfig & cmake.
Let's fix them.
As a bonus, as for kconfig the BOARD_TARGET_STRING is the
same for the hwmv1 backwards compatible name, let's
just remove the check for the old names.

(cherry picked from commit f336026)

Original-Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
GitOrigin-RevId: f336026
Change-Id: Iba45a96a3f1ee7dce257f719eb5c7f74b597f314
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5387784
Tested-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiobaltieri fabiobaltieri fabiobaltieri approved these changes

@carlescufi carlescufi carlescufi approved these changes

@gmarull gmarull gmarull approved these changes

@nordicjm nordicjm nordicjm approved these changes

@nashif nashif Awaiting requested review from nashif

@henrikbrixandersen henrikbrixandersen Awaiting requested review from henrikbrixandersen

@57300 57300 Awaiting requested review from 57300

@abrodkin abrodkin Awaiting requested review from abrodkin

@evgeniy-paltsev evgeniy-paltsev Awaiting requested review from evgeniy-paltsev

@galak galak Awaiting requested review from galak

@jeremybettis jeremybettis Awaiting requested review from jeremybettis

@ruuddw ruuddw Awaiting requested review from ruuddw

@jfischer-no jfischer-no Awaiting requested review from jfischer-no

@kartben kartben Awaiting requested review from kartben

@keith-zephyr keith-zephyr Awaiting requested review from keith-zephyr

@stephanosio stephanosio Awaiting requested review from stephanosio

Assignees

@tejlmand tejlmand

Labels
area: Board/SoC configuration area: Build System area: Coding Guidelines Coding guidelines and style area: Continuous Integration area: Devicetree area: Kconfig area: Sysbuild area: West West utility platform: Synopsys Synopsys
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tejlmand @nordicjm @fabiobaltieri @carlescufi @gmarull @zephyrbot