Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fallthrough on sample_channel_get on AQI #74032

Merged
merged 1 commit into from
Jun 12, 2024
Merged

fix fallthrough on sample_channel_get on AQI #74032

merged 1 commit into from
Jun 12, 2024

Conversation

KryQ
Copy link
Contributor

@KryQ KryQ commented Jun 10, 2024

There is a small bug present in ENS161 sensor driver where while getting samples for AQI logging return ERRNO -134
Cause was a lack of break in switch statement.

@zephyrbot zephyrbot added area: Sensors Sensors size: XS A PR changing only a single line of code labels Jun 10, 2024
Copy link

Hello @KryQ, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

Copy link
Member

@ubieda ubieda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@teburd teburd added the bug The issue is a bug, or the PR is fixing a bug label Jun 10, 2024
@teburd teburd added this to the v3.7.0 milestone Jun 10, 2024
@kartben
Copy link
Collaborator

kartben commented Jun 12, 2024

@KryQ almost there with compliance check - please amend git author name/email to match the sign-off entry

fixed fallthrough on getting channel AQI value from ENS160

Signed-off-by: Krystian Dolatowski <kryqpl1@gmail.com>
@kartben kartben added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Jun 12, 2024
@nashif nashif merged commit 317abcc into zephyrproject-rtos:main Jun 12, 2024
24 checks passed
Copy link

Hi @KryQ!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Sensors Sensors bug The issue is a bug, or the PR is fixing a bug size: XS A PR changing only a single line of code Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants