Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bluetooth: Controller: nRF51x: Use BT_LL_SW_LLCP_LEGACY #75197

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Bluetooth: Controller: nRF51x: Use BT_LL_SW_LLCP_LEGACY #75197

wants to merge 14 commits into from
+8,579 −226

Conversation

cvinayak
Copy link
Contributor

@cvinayak cvinayak commented Jun 29, 2024 •
edited
Loading

Related to #74345.

@cvinayak cvinayak force-pushed the github_llcp_legacy branch 3 times, most recently from 2473abe to 7456529 Compare June 30, 2024 01:30
@cvinayak cvinayak mentioned this pull request Jul 8, 2024
Open
@thedjnK
Copy link
Collaborator

thedjnK commented Jul 10, 2024

Seems I'm still getting weird issues with this, e.g.:

E: ***** HARD FAULT *****
E: ARCH_EXCEPT with reason 3

E: r0/a1:  0x00000003  r1/a2:  0x0203001b  r2/a3:  0x40001000
E: r3/a4:  0x00000003 r12/ip:  0x000f6c74 r14/lr:  0x00016099
E:  xpsr:  0x01000011
E: Faulting instruction address (r15/pc): 0x000160a8
E: >>> ZEPHYR FATAL ERROR 3: Kernel oops on CPU 0
E: Fault during interrupt handling

E: Current thread: 0x20000ff8 (sysworkq)
E: Halting system

which is: zephyr/subsys/bluetooth/controller/ll_sw/nordic/lll/lll_conn.c:403 (discriminator 3)

@thedjnK
Copy link
Collaborator

thedjnK commented Jul 11, 2024

Seemingly haven't been able to replicate that issue again, does seem to be working, thanks @cvinayak !

@cvinayak
Copy link
Contributor Author

Seemingly haven't been able to replicate that issue again, does seem to be working, thanks @cvinayak !

I will rebase after Zephyr v3.7.0 release, and tag it in my github fork. If anyone wants to use it for there old nrf51 SoC boards, they can maintain it as required.

@cvinayak cvinayak force-pushed the github_llcp_legacy branch 5 times, most recently from d2ea47e to 0465200 Compare July 20, 2024 01:13
@github-actions github-actions bot added the Stale label Sep 27, 2024
@cvinayak cvinayak removed the Stale label Sep 27, 2024
@zephyrproject-rtos zephyrproject-rtos deleted a comment from github-actions bot Sep 27, 2024
@cvinayak
Revert "Bluetooth: controller: remove refs to LLCP_LEGACY after rebase"
4cfdcda 
This reverts commit 4215854.

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
@cvinayak
Revert "Bluetooth: controller: remove dependency for slot reservation"
30e8224 
This reverts commit e6a3def.

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
@cvinayak
Revert "Bluetooth: controller: remove code related to advanced schedu…
56360f0 
…ling"

This reverts commit 729c3e3.

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
@cvinayak
Revert "Blueotooth: controller: removed delayed notification code"
302c222 
This reverts commit f6172f3.

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
@cvinayak cvinayak force-pushed the github_llcp_legacy branch 2 times, most recently from 4c9dafe to a7f2fff Compare October 13, 2024 05:01
@cvinayak
Copy link
Contributor Author

Seemingly haven't been able to replicate that issue again, does seem to be working, thanks @cvinayak !

I will rebase after Zephyr v3.7.0 release, and tag it in my github fork. If anyone wants to use it for there old nrf51 SoC boards, they can maintain it as required.

Tagged before rebase to latest upstream (not v3.7.0, but later though): https://github.com/cvinayak/zephyr/releases/tag/bt_ctlr_llcp_legacy_202407

@cvinayak
Revert "Bluetooth: controller: removing legacy LLCP code"
299e9d9 
This reverts commit 2ada005.

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
@cvinayak
Revert "Bluetooth: Controller: Remove legacy BT_CTLR_FAST_ENC option"
1aee8b5 
This reverts commit a5e7ba3.

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
@cvinayak
Revert "Bluetooth: Controller: Porting legacy Accept CIS procedure"
8e509a0 
This is a manual fix to have Peripheral CIS procedure in
legacy LLCP.

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
@cvinayak
Revert "Bluetooth: Controller: Porting legacy llcp procedure"
f08d0ee 
This is a manual fix to have legacy LLCP compiling

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
@cvinayak
Bluetooth: Controller: Use reference conn event count in CPR
f5e0711 
Update implementation to correctly use reference connection
event count present in the Connection Parameter Request PDU
and the connection event when the window offset is selected
to perform the Connection Update.

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
@cvinayak
Bluetooth: Controller: Updates to win_offset_calc
8882790 
Fix the advanced scheduling implementation of
win_offset_calc() function to consider both active central
and active peripheral roles as occupied timespace when
determining the free timespace available to fill the offsets
in the connection parameter request PDU.

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
@cvinayak
Bluetooth: Controller: Re-grouping conn updates of same interval
23413c9 
Add implementation to find free connection offsets after a
connection of same interval. This is re-group connection of
same interval when Connection Parameter Request procedure is
performed from different connection intervals.

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
@cvinayak
tests: Bluetooth: bsim: Add test for auto connection parameter update
6dbc301 
Add BabbleSim test to cover the automatic preferred
peripheral connection parameter requests across multiple
simultaneous connections.

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
@cvinayak
Bluetooth: Controller: nRF51x: Use BT_LL_SW_LLCP_LEGACY
2fb5ea0 
Use BT_LL_SW_LLCP_LEGACY for nRF51x SoCs.

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
@cvinayak
Bluetooth: Controller: nRF51x: Enable Privacy Support
664c6ec 
Enable Privacy Support, upto 2 bonds tested to have
no issues when using a modified peripheral_accept_list.

Relates to commit 93ca60b ("Bluetooth: controller:
Require nRF52 for privacy").

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cvinayak @thedjnK