sensor: tsl2591: fix: Address CID 353644 & 353654 #76669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes implicit sign-extension/potential overflow by explicitly casting to int64_t. Signed-off-by: Kurtis Dinelle <kurtisdinelle@gmail.com>
zephyrbot
added
area: Sensors
zephyrbot
requested review from
avisconti,
jeppenodgaard,
MaureenHelm,
teburd,
tristan-google,
ubieda and
yperess
MaureenHelm
approved these changes
Oct 1, 2024
ubieda
approved these changes
Oct 2, 2024
aescolar
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverity is concerned about potential overflow from implicit sign extension in multiplication operation (since operands are implicitly promoted to
int32_t, which twouint16_t's could theoretically overflow when multiplied together before the result is cast toint64_t). Although this shouldn't happen in practice due to the range of values operands can take on, perform explicit cast toint64_ton operands just to be on the safe side.Fixes #74750
Fixes #74752