This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
Handle scientific notation in argument initializers #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently ethereumjs-abi is using a version of bignumber that fails to properly parse a number of the form '20e10'. To workaround this, we pre-parse all arguments, pass them through bignumber, and then send them to the encode function. Fixes #327
facuspagnuolo
approved these changes
Oct 25, 2018
facuspagnuolo
added
status:on-hold
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently ethereumjs-abi is using a version of bignumber that fails to
properly parse a number of the form '20e10'. To workaround this, we
pre-parse all arguments, pass them through bignumber, and then send them
to the encode function.
Fixes #327