Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(conversation-list/labels): apply ordering logic to favorites and all labels #2131

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Jul 26, 2024

What does this do?

  • applies ordering logic to favorites and all labels i.e.:
Once >=1 conversation is Favorited, the Favorites list should be the first filter in the label selector. If nothing is favorited it would go back to all.
Can we default 'Favorites' if Favorites List >=1 and then have All second
  • replaces 'Favorites' text label with a star icon

Why are we making this change?

  • design request

How do I test this?

  • run ui as usual and test favorite tagging.
  • run tests as usual

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?
fav.mov

@domw30 domw30 requested a review from a team July 26, 2024 12:22
@domw30 domw30 merged commit 7cb73eb into main Jul 26, 2024
5 checks passed
@domw30 domw30 deleted the refactor/favorites-label-logic branch July 26, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant