Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: adjust the height of the unread count tag badge #2143

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Aug 2, 2024

What does this do?

  • adjusts the height of the unread count tag badge

Why are we making this change?

  • design request

How do I test this?

  • run tests as usual
  • run ui and check unread count tag badge (as per below)

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?

BEFORE

Screenshot 2024-08-02 at 07 45 56

AFTER

Screenshot 2024-08-02 at 07 45 03

@domw30 domw30 requested a review from a team August 2, 2024 06:46
@domw30 domw30 merged commit bf6f004 into main Aug 2, 2024
5 checks passed
@domw30 domw30 deleted the refactor--height-of-unread-count-tab-badge branch August 2, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant