Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wire up creating unencrypted room & add ui #2163

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Aug 12, 2024

What does this do?

  • adds checkbox to group details panel

Why are we making this change?

  • so a user can optionally choose to create an unencrypted room or encrypted room

How do I test this?

  • run tests as usual

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?
Screenshot 2024-08-12 at 12 02 30

@domw30 domw30 requested a review from a team August 12, 2024 11:10
Base automatically changed from feat/add-support-for-creating-unencrypted-channels to main August 12, 2024 11:20
@domw30 domw30 merged commit 1bd7b4b into main Aug 12, 2024
5 checks passed
@domw30 domw30 deleted the feat/wire-up-ui-for-creating-unencrypted-groups branch August 12, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant