Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add menu class names to handle and improve select input dropdown menu width sizes #2172

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Aug 14, 2024

What does this do?

  • add width to select input dropdown menu to align with width of the select input

Why are we making this change?

  • as per design

How do I test this?

  • run tests as usual

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?
Screenshot 2024-08-14 at 10 49 59

@domw30 domw30 requested a review from a team August 14, 2024 09:50
@domw30 domw30 merged commit 3ae94b0 into main Aug 14, 2024
5 checks passed
@domw30 domw30 deleted the feat/handle-select-input-widths branch August 14, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant