Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(matrix-client/messages-saga): bypass encrypting files during upload if non encrypted room #2184

Merged

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Aug 20, 2024

What does this do?

  • This update bypasses the encryption process for file uploads in non-encrypted rooms, optimizing performance and ensuring correct file handling.

Why are we making this change?

  • We are making this change to prevent unnecessary encryption in non-encrypted rooms, improving the efficiency of file uploads and maintaining consistent behavior across different room types.

How do I test this?

  • run ui and send images in non encrypted rooms then refresh

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?

@domw30 domw30 requested a review from a team August 20, 2024 11:28
@domw30 domw30 merged commit 1d395e4 into main Aug 20, 2024
5 checks passed
@domw30 domw30 deleted the fix/bypass-encrypting-image-during-upload-if-non-encrypted-room branch August 20, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant