Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(posts-saga): add posts store saga and actions #2186

Merged
merged 6 commits into from
Aug 21, 2024
Merged

feat(posts-saga): add posts store saga and actions #2186

merged 6 commits into from
Aug 21, 2024

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Aug 21, 2024

What does this do?

  • adds posts store saga, reducer and actions (sendPost, fetchPosts)
  • adds test coverage

Why are we making this change?

  • separation of posts and messages

How do I test this?

  • run tests as usual
  • this saga is not yet wired up

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?

@domw30 domw30 requested a review from a team August 21, 2024 22:27
@domw30 domw30 merged commit 5aa9f6f into main Aug 21, 2024
5 checks passed
@domw30 domw30 deleted the feat/add-posts-store-saga-and-actions branch August 21, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@domw30