Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(matrix-client): optimize event handling in message retrieval by reducing redundant liveTimeline calls #2198

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Aug 23, 2024

What does this do?

This change optimizes the retrieval of chat and post messages by reducing redundant calls to the liveTimeline. The events are now retrieved once and passed down, improving the overall performance of the message fetching process.

Why are we making this change?

We are making this change to enhance the performance of the application by minimizing unnecessary calls to the liveTimeline, which can be resource-intensive. This optimization reduces the load on the system and improves the efficiency of message handling.

How do I test this?

  • run tests as usual.

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?

@domw30 domw30 requested a review from a team August 23, 2024 11:45
@domw30 domw30 merged commit e940ea7 into main Aug 23, 2024
5 checks passed
@domw30 domw30 deleted the refactor/optimize-event-handling-in-message-retrieval-by-reducing-redundant-liveTimeline-calls branch August 23, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant