Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ability to Add a wallet to an email account (UI) #2239

Merged
merged 7 commits into from
Sep 4, 2024

Conversation

ratik21
Copy link
Collaborator

@ratik21 ratik21 commented Sep 4, 2024

What does this do?

Adds UI for supporting "Add Wallet", if a user has signed in via an email account. This is currently feature flagged under enableAddWallets key.

  • User can click on + Add Wallet button to link a new wallet
  • If metamask is already connected, then just directly show the Modal (sc)
  • otherwise, user is prompted to connect their wallet first, and then the modal is shown
  • this also fixes some of the global state management using rainbowKit/connect. we weren't storing the walletAddress, and the connectedId correctly in our redux state before.

(Add wallets button)
image

(if wallet is already connected)
image

(if not, connect wallet first)
image
image

Follow ups

  • Saga logic
  • backend integration

@ratik21 ratik21 requested a review from a team September 4, 2024 08:15
@ratik21 ratik21 merged commit 8b7a316 into main Sep 4, 2024
5 checks passed
@ratik21 ratik21 deleted the ratik/zos-73-add-new-wallet branch September 4, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant