Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update class name to fix message input margin #760

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Jul 10, 2023

What does this do?

  • fixes the margin for the compose a message input.

Why are we making this change?

  • this change is to fix the margin to what is currently in production. This was not an intended design change, therefore the fix is required.

How do I test this?

  • open the app (not in full screen) and check the message input has equal margins as per screenshots below.

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?

Before:
Screenshot 2023-07-10 at 10 28 36

Screenshot 2023-07-10 at 10 28 26

After:
Screenshot 2023-07-10 at 10 28 18

@domw30 domw30 requested a review from a team July 10, 2023 08:32
Copy link
Collaborator

@ratik21 ratik21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing

@domw30 domw30 merged commit 1a38b20 into main Jul 10, 2023
@domw30 domw30 deleted the fix/message-input-margin branch July 10, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants