Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: populate messages from the bottom up #853

Merged
merged 1 commit into from
Jul 26, 2023
Merged

feat: populate messages from the bottom up #853

merged 1 commit into from
Jul 26, 2023

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Jul 25, 2023

What does this do?

  • populates messages (where the container uses InvertedScroll from the bottom up.

Why are we making this change?

  • as per figma designs / product request.

How do I test this?

  • open messenger fullscreen or collapsed direct message and check that messages are populated from the bottom up - as per screenshots below.

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?

Before:

Screenshot 2023-07-25 at 15 42 57

After:

Screenshot 2023-07-25 at 15 43 27

@domw30 domw30 requested a review from a team July 25, 2023 14:43
dalefukami
dalefukami approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@dalefukami dalefukami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'm glad that ended up working out.

@domw30 domw30 merged commit af974ad into main Jul 26, 2023
4 checks passed
@domw30 domw30 deleted the feat/populate-messages-bottom-up branch July 26, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalefukami dalefukami dalefukami approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domw30 @dalefukami