Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

superklue docked docking ports while in flight 🧷 #24

Closed
zer0Kerbal opened this issue Oct 1, 2021 · 2 comments · Fixed by #59
Closed

superklue docked docking ports while in flight 🧷 #24

zer0Kerbal opened this issue Oct 1, 2021 · 2 comments · Fixed by #59
Assignees
@zer0Kerbal
Labels
help wanted assistance, help, input solicited
Projects
Kaboom! version 1.4.0.0 Superglue Bug Triage

Comments

@zer0Kerbal
Copy link
Owner

zer0Kerbal commented Oct 1, 2021 •
edited
Loading

from @Robin Patenall
image

glue kabooming docked docking ports something that might be considered

related: #23 #5
@zer0Kerbal zer0Kerbal added this to the superglue docked docking ports while in flight milestone Oct 1, 2021
@zer0Kerbal zer0Kerbal self-assigned this Oct 1, 2021
@zer0Kerbal zer0Kerbal added code-issue help wanted assistance, help, input solicited labels Oct 1, 2021
@zer0Kerbal
Copy link
Owner Author

what do you think @yarlov ?

@zer0Kerbal zer0Kerbal added this to To do in Kaboom! version 1.4.0.0 via automation Oct 1, 2021
@zer0Kerbal zer0Kerbal added this to To do in Superglue via automation Oct 1, 2021
@RobotGuy
Copy link

RobotGuy commented Oct 1, 2021

Just to follow up from my comment in the KSP forum, gluing docking ports that were docked in flight doesn't work, only those docked in the VAB. I've included a save file with some examples.

  • The docking ports between the hub and the large fuel tank was docked in the VAB, these will glue
  • The docking ports between the hubs were multi-docked in orbit, these don't glue
  • The docking ports between the hub and the command pod bit were simply docked in orbit, these don't glue

The only mods in this save game was Kaboom! (the latest Beta), Module manager and the Breaking Ground DLC.
Kaboom Save.zip

@zer0Kerbal zer0Kerbal added this to Needs triage in Bug Triage Oct 1, 2021
@zer0Kerbal zer0Kerbal moved this from To do to In progress in Superglue Oct 8, 2021
@zer0Kerbal zer0Kerbal moved this from Needs triage to High priority in Bug Triage Oct 9, 2021
@zer0Kerbal zer0Kerbal changed the title superglue docked docking ports while in flight 🧷 superklue docked docking ports while in flight 🧷 Oct 26, 2021
zer0Kerbal added a commit that referenced this issue Oct 26, 2021
@zer0Kerbal
Version 1.4.0.0 - SuperKlue Implosions!!
676819d 
# Version 1.4.0.0 - SuperKlue Implosions!!
- 25 Oct 2021
- Kerbal Space Program [KSP 1.12.2]
### Added

- added ![][ES] Spanish (Español) (thank you [Tacombel][LINK:tacombel])
- added ![]{RU] Russian (Русский) (thank you [Forums: Flart][LINK:flart] - [Github: yalov][LINK:yalov])
- ***your translation here***

### `Code'

- thank you to ['@flart'][LINK:flart] aka [yalov][LINK:yalov]
- if glued kaboom is enabled and there was in-flight docking, docking ports kaboom together
- longer ScreenMessage
- remove unnecessary usings
- update .csproj

### Updated

- Documentation
  - readme
  - release notes
  - Attribution

### Status

- Features/Issues/Milestones
    - closes #20 - duplicate
    - closes #21 - duplicate
    - closes #22 - duplicate
    - closes #23 - Dev kaboom superglue [pull request] contributed by zer0Kerbal
    - closes #32 - Kaboom Safety Cover not localized
    - closes #35 - 1.3.99.2 beta 3 beta - contributed by zer0Kerbal
    - closes #36 - Create es-es.cfg - contributed by Tacombel
    - closes #37 - Localization - English (United States)] <en-us.cfg> - contributed by zer0Kerbal
    - closes #42 - Localization - Russian (Русский) <ru.cfg> - contributed by yalov
    - closes #52 - Localization - Spanish (Español) <es-es.cfg> - contributed by Tacombel
    - closes #57 - localization fixes + ru - contributed by yalov
    - closes #58 - update ru.cfg localization- contributed by yalov
    - updates #33 - Localization project - contributed by zer0kerbal
- Bug
    - closes #24 - superklue docked docking ports while in flight - thank you to @robin Patenall
    - closes #54 - typo
    - closes #56 - seconds not localized
- *** Possible future changes ***
    - #39, #40, #41, #43, #44, #45, #46, #47, #48, #49, #50, #51 and #53 - more localizations
    - #25 - auto destruct during launch
    - #17, #18 - bigger boom, bigger badda-boom
    - #16 - boom stick
    - #1 - staging
@zer0Kerbal zer0Kerbal mentioned this issue Oct 26, 2021
Merged
Kaboom! version 1.4.0.0 automation moved this from To do to Done Oct 26, 2021
Superglue automation moved this from In progress to Done Oct 26, 2021
Bug Triage automation moved this from High priority to Closed Oct 26, 2021
zer0Kerbal added a commit that referenced this issue Oct 26, 2021
@zer0Kerbal
Merge pull request #59 from zer0Kerbal/1.4.0.0-prerelease
1f24791 
# Version 1.4.0.0 - SuperKlue Implosions!!
- 25 Oct 2021  
- Kerbal Space Program [KSP 1.12.2]
### Added  

- added ![][ES] Spanish (Español) (thank you [Tacombel][LINK:tacombel])
- added ![][RU] Russian (Русский) (thank you [Forums: Flart][LINK:flart] - [Github: yalov][LINK:yalov])
- ***your translation here***

### `Code'

- thank you to ['@flart'][LINK:flart] aka [yalov][LINK:yalov]
- if glued kaboom is enabled and there was in-flight docking, docking ports kaboom together
- longer ScreenMessage
- remove unnecessary usings
- update .csproj

### Updated

- Documentation
  - readme
  - release notes
  - Attribution
  
### Status

- Features/Issues/Milestones
    - closes #20 - duplicate
    - closes #21 - duplicate
    - closes #22 - duplicate
    - closes #23 - Dev kaboom superglue [pull request] contributed by zer0Kerbal
    - closes #32 - Kaboom Safety Cover not localized
    - closes #35 - 1.3.99.2 beta 3 beta - contributed by zer0Kerbal
    - closes #36 - Create es-es.cfg - contributed by Tacombel
    - closes #37 - Localization - English (United States)] <en-us.cfg> - contributed by zer0Kerbal
    - closes #42 - Localization - Russian (Русский) <ru.cfg> - contributed by yalov
    - closes #52 - Localization - Spanish (Español) <es-es.cfg> - contributed by Tacombel
    - closes #57 - localization fixes + ru - contributed by yalov
    - closes #58 - update ru.cfg localization- contributed by yalov
    - updates #33 - Localization project - contributed by zer0kerbal
- Bug
    - closes #24 - superklue docked docking ports while in flight - thank you to @robin Patenall
    - closes #54 - typo
    - closes #56 - seconds not localized
- *** Possible future changes ***
    - #39, #40, #41, #43, #44, #45, #46, #47, #48, #49, #50, #51 and #53 - more localizations 
    - #25 - auto destruct during launch
    - #17, #18 - bigger boom, bigger badda-boom
    - #16 - boom stick
    - #1 - staging

[RU]: https://raw.githubusercontent.com/zer0Kerbal/zer0Kerbal/zed'K/Localization/img/Russian-flag-sm.png "Русский" 
[ES]: https://raw.githubusercontent.com/zer0Kerbal/zer0Kerbal/zed'K/Localization/img/Spanish-flag-sm.png "Español" 
[EN]: https://raw.githubusercontent.com/zer0Kerbal/zer0Kerbal/zed'K/Localization/img/American-flag-sm.png "American English" 
[LINK:russnash37]: https://forum.kerbalspaceprogram.com/index.php?/profile/77512-russnash37/ "Forums: RussNash37"  
[LINK:russnash]: https://github.com/russnash "GitHub: russnash"  
[LINK:tacombel]: https://github.com/Tacombel "Tacombel"  
[LINK:flart]: https://forum.kerbalspaceprogram.com/index.php?/profile/181486-flart/ "Flart"  
[LINK:yalov]: https://github.com/yalov "yalov"  
[LINK:zer0Kerbal]: https://forum.kerbalspaceprogram.com/index.php?/profile/190933-zer0kerbal/ "zer0Kerbal"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zer0Kerbal zer0Kerbal

Labels
help wanted assistance, help, input solicited
Projects
No open projects
Bug Triage
  
Closed
Kaboom! version 1.4.0.0
  
Done
Superglue
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version 1.4.0.0 - SuperKlue Implosions!! zer0Kerbal/Kaboom
2 participants
@RobotGuy @zer0Kerbal