Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

localization fixes + ru #57

Merged
merged 5 commits into from
Oct 14, 2021
Merged

localization fixes + ru #57

merged 5 commits into from
Oct 14, 2021

Conversation

yalov
Copy link

@yalov yalov commented Oct 13, 2021 •
edited by zer0Kerbal

@yalov yalov changed the title localization fixes localization fixes + ru Oct 13, 2021
zer0Kerbal
zer0Kerbal reviewed Oct 14, 2021
View reviewed changes
source/Kaboom.cs
@@ -58,11 +58,11 @@ public override void OnStart(StartState state)
base.OnStart(state);

if (HighLogic.CurrentGame.Parameters.CustomParams<KaboomSettings>().coloredPAW)
//Fields["delay"].group.displayName = Localizer.Format("<color=red>#BOOM-SafetyCover</color>");
Fields["delay"].group.displayName = "<color=red>Kaboom Safety Cover</color>";
Fields["delay"].group.displayName = Localizer.Format("#BOOM-SafetyCoverColor");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer the color to remain in the code; keeps things simple for those who translate IMHO.

Fields["delay"].group.displayName = System.String.Format("<color=red>" + Localizer.Format("Kaboom Safety Cover") + "</color>");

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually put color tag to the loc file, so users could change colors if needed

@zer0Kerbal zer0Kerbal self-assigned this Oct 14, 2021
@zer0Kerbal zer0Kerbal added this to In progress in Localization via automation Oct 14, 2021
@zer0Kerbal zer0Kerbal added this to In progress in Kaboom! version 1.4.0.0 via automation Oct 14, 2021
@zer0Kerbal zer0Kerbal added this to the 1.3.99.2-Beta-3 milestone Oct 14, 2021
zer0Kerbal
zer0Kerbal previously approved these changes Oct 14, 2021
View reviewed changes
@zer0Kerbal zer0Kerbal dismissed their stale review October 14, 2021 02:44

not ready yet

zer0Kerbal
zer0Kerbal reviewed Oct 14, 2021
View reviewed changes
GameData/Kaboom/Localization/en-us.cfg
@@ -16,7 +16,6 @@ Localization
#BOOM-modnameV = Kaboom! v<<1>>

// ********** Type: Kaboom.ModuleKaboom, KSP Fields, Events
#BOOM-GroupName = Kaboom
#BOOM-delay = Kaboom delay
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#BOOM-modname probably can be used for multiple instances in order to simplify and streamline.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#BOOM-modname is there, I removed #BOOM-GroupName because GroupName is internal and need to be English

@zer0Kerbal
Copy link
Owner

again, thank you @yalov !

@zer0Kerbal zer0Kerbal merged commit 2049527 into zer0Kerbal:1.4.0.0-prerelease Oct 14, 2021
Kaboom! version 1.4.0.0 automation moved this from In progress to Done Oct 14, 2021
Localization automation moved this from In progress to Done Oct 14, 2021
zer0Kerbal added a commit that referenced this pull request Oct 26, 2021
@zer0Kerbal
Version 1.4.0.0 - SuperKlue Implosions!!
676819d 
# Version 1.4.0.0 - SuperKlue Implosions!!
- 25 Oct 2021
- Kerbal Space Program [KSP 1.12.2]
### Added

- added ![][ES] Spanish (Español) (thank you [Tacombel][LINK:tacombel])
- added ![]{RU] Russian (Русский) (thank you [Forums: Flart][LINK:flart] - [Github: yalov][LINK:yalov])
- ***your translation here***

### `Code'

- thank you to ['@flart'][LINK:flart] aka [yalov][LINK:yalov]
- if glued kaboom is enabled and there was in-flight docking, docking ports kaboom together
- longer ScreenMessage
- remove unnecessary usings
- update .csproj

### Updated

- Documentation
  - readme
  - release notes
  - Attribution

### Status

- Features/Issues/Milestones
    - closes #20 - duplicate
    - closes #21 - duplicate
    - closes #22 - duplicate
    - closes #23 - Dev kaboom superglue [pull request] contributed by zer0Kerbal
    - closes #32 - Kaboom Safety Cover not localized
    - closes #35 - 1.3.99.2 beta 3 beta - contributed by zer0Kerbal
    - closes #36 - Create es-es.cfg - contributed by Tacombel
    - closes #37 - Localization - English (United States)] <en-us.cfg> - contributed by zer0Kerbal
    - closes #42 - Localization - Russian (Русский) <ru.cfg> - contributed by yalov
    - closes #52 - Localization - Spanish (Español) <es-es.cfg> - contributed by Tacombel
    - closes #57 - localization fixes + ru - contributed by yalov
    - closes #58 - update ru.cfg localization- contributed by yalov
    - updates #33 - Localization project - contributed by zer0kerbal
- Bug
    - closes #24 - superklue docked docking ports while in flight - thank you to @robin Patenall
    - closes #54 - typo
    - closes #56 - seconds not localized
- *** Possible future changes ***
    - #39, #40, #41, #43, #44, #45, #46, #47, #48, #49, #50, #51 and #53 - more localizations
    - #25 - auto destruct during launch
    - #17, #18 - bigger boom, bigger badda-boom
    - #16 - boom stick
    - #1 - staging
@zer0Kerbal zer0Kerbal mentioned this pull request Oct 26, 2021
Merged
zer0Kerbal added a commit that referenced this pull request Oct 26, 2021
@zer0Kerbal
Merge pull request #59 from zer0Kerbal/1.4.0.0-prerelease
1f24791 
# Version 1.4.0.0 - SuperKlue Implosions!!
- 25 Oct 2021  
- Kerbal Space Program [KSP 1.12.2]
### Added  

- added ![][ES] Spanish (Español) (thank you [Tacombel][LINK:tacombel])
- added ![][RU] Russian (Русский) (thank you [Forums: Flart][LINK:flart] - [Github: yalov][LINK:yalov])
- ***your translation here***

### `Code'

- thank you to ['@flart'][LINK:flart] aka [yalov][LINK:yalov]
- if glued kaboom is enabled and there was in-flight docking, docking ports kaboom together
- longer ScreenMessage
- remove unnecessary usings
- update .csproj

### Updated

- Documentation
  - readme
  - release notes
  - Attribution
  
### Status

- Features/Issues/Milestones
    - closes #20 - duplicate
    - closes #21 - duplicate
    - closes #22 - duplicate
    - closes #23 - Dev kaboom superglue [pull request] contributed by zer0Kerbal
    - closes #32 - Kaboom Safety Cover not localized
    - closes #35 - 1.3.99.2 beta 3 beta - contributed by zer0Kerbal
    - closes #36 - Create es-es.cfg - contributed by Tacombel
    - closes #37 - Localization - English (United States)] <en-us.cfg> - contributed by zer0Kerbal
    - closes #42 - Localization - Russian (Русский) <ru.cfg> - contributed by yalov
    - closes #52 - Localization - Spanish (Español) <es-es.cfg> - contributed by Tacombel
    - closes #57 - localization fixes + ru - contributed by yalov
    - closes #58 - update ru.cfg localization- contributed by yalov
    - updates #33 - Localization project - contributed by zer0kerbal
- Bug
    - closes #24 - superklue docked docking ports while in flight - thank you to @robin Patenall
    - closes #54 - typo
    - closes #56 - seconds not localized
- *** Possible future changes ***
    - #39, #40, #41, #43, #44, #45, #46, #47, #48, #49, #50, #51 and #53 - more localizations 
    - #25 - auto destruct during launch
    - #17, #18 - bigger boom, bigger badda-boom
    - #16 - boom stick
    - #1 - staging

[RU]: https://raw.githubusercontent.com/zer0Kerbal/zer0Kerbal/zed'K/Localization/img/Russian-flag-sm.png "Русский" 
[ES]: https://raw.githubusercontent.com/zer0Kerbal/zer0Kerbal/zed'K/Localization/img/Spanish-flag-sm.png "Español" 
[EN]: https://raw.githubusercontent.com/zer0Kerbal/zer0Kerbal/zed'K/Localization/img/American-flag-sm.png "American English" 
[LINK:russnash37]: https://forum.kerbalspaceprogram.com/index.php?/profile/77512-russnash37/ "Forums: RussNash37"  
[LINK:russnash]: https://github.com/russnash "GitHub: russnash"  
[LINK:tacombel]: https://github.com/Tacombel "Tacombel"  
[LINK:flart]: https://forum.kerbalspaceprogram.com/index.php?/profile/181486-flart/ "Flart"  
[LINK:yalov]: https://github.com/yalov "yalov"  
[LINK:zer0Kerbal]: https://forum.kerbalspaceprogram.com/index.php?/profile/190933-zer0kerbal/ "zer0Kerbal"
@zer0Kerbal zer0Kerbal added the type: localization related to localization and translations label Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zer0Kerbal zer0Kerbal zer0Kerbal left review comments

Assignees

@zer0Kerbal zer0Kerbal

Labels
type: localization related to localization and translations
Projects
Localization
  
Done
Kaboom! version 1.4.0.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yalov @zer0Kerbal