Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seconds not localized #56

Closed
Tacombel opened this issue Oct 12, 2021 · 5 comments · Fixed by #59
Closed

Seconds not localized #56

Tacombel opened this issue Oct 12, 2021 · 5 comments · Fixed by #59
Assignees
@zer0Kerbal
Projects
Kaboom! version 1.4.0.0 Bug Triage
Milestone
Localization - Ma...

Comments

@Tacombel
Copy link

image
@github-actions
Copy link

Thank you. Kindly read contributiing.md, code_of_conduct.md and styleguide.md

@Tacombel
Copy link
Author

Kindly read contributiing.md, code_of_conduct.md and styleguide.md

Where are those docs?

@zer0Kerbal zer0Kerbal self-assigned this Oct 12, 2021
@zer0Kerbal zer0Kerbal added this to To do in Kaboom! version 1.4.0.0 via automation Oct 12, 2021
@zer0Kerbal zer0Kerbal added this to Needs triage in Bug Triage via automation Oct 12, 2021
@zer0Kerbal zer0Kerbal added this to To do in Localization via automation Oct 12, 2021
@zer0Kerbal zer0Kerbal moved this from Needs triage to Low priority in Bug Triage Oct 12, 2021
@zer0Kerbal zer0Kerbal moved this from To do to In progress in Kaboom! version 1.4.0.0 Oct 12, 2021
@zer0Kerbal zer0Kerbal moved this from To do to In progress in Localization Oct 12, 2021
@zer0Kerbal zer0Kerbal added this to the Localization milestone Oct 12, 2021
@github-actions
Copy link

Thank you. Kindly read contributiing.md, code_of_conduct.md and styleguide.md

@zer0Kerbal
Copy link
Owner

zer0Kerbal commented Oct 12, 2021 •
edited
Loading

Kindly read contributiing.md, code_of_conduct.md and styleguide.md

Where are those docs?

got me - I moved them to the zer0Kerbal/.github repo and forgot to update the links and the greeting workflow. Should be fixed now. Boilerplate - same for all my repositories.

@zer0Kerbal
Copy link
Owner

Thank you! @Tacombel 👍
and fixing that now in code. won't issue new release - so will show up in next release.

zer0Kerbal added a commit that referenced this issue Oct 25, 2021
@zer0Kerbal
localization fixes
8b9c3a7 
# Localization fixes
- fix localization of PAW group
- advances Localization - Master  #38
- closes #32 - Kaboom Safety Cover not localized
- closes #56
- updates #55
- closes #54
- closes #37
zer0Kerbal added a commit that referenced this issue Oct 26, 2021
@zer0Kerbal
Version 1.4.0.0 - SuperKlue Implosions!!
676819d 
# Version 1.4.0.0 - SuperKlue Implosions!!
- 25 Oct 2021
- Kerbal Space Program [KSP 1.12.2]
### Added

- added ![][ES] Spanish (Español) (thank you [Tacombel][LINK:tacombel])
- added ![]{RU] Russian (Русский) (thank you [Forums: Flart][LINK:flart] - [Github: yalov][LINK:yalov])
- ***your translation here***

### `Code'

- thank you to ['@flart'][LINK:flart] aka [yalov][LINK:yalov]
- if glued kaboom is enabled and there was in-flight docking, docking ports kaboom together
- longer ScreenMessage
- remove unnecessary usings
- update .csproj

### Updated

- Documentation
  - readme
  - release notes
  - Attribution

### Status

- Features/Issues/Milestones
    - closes #20 - duplicate
    - closes #21 - duplicate
    - closes #22 - duplicate
    - closes #23 - Dev kaboom superglue [pull request] contributed by zer0Kerbal
    - closes #32 - Kaboom Safety Cover not localized
    - closes #35 - 1.3.99.2 beta 3 beta - contributed by zer0Kerbal
    - closes #36 - Create es-es.cfg - contributed by Tacombel
    - closes #37 - Localization - English (United States)] <en-us.cfg> - contributed by zer0Kerbal
    - closes #42 - Localization - Russian (Русский) <ru.cfg> - contributed by yalov
    - closes #52 - Localization - Spanish (Español) <es-es.cfg> - contributed by Tacombel
    - closes #57 - localization fixes + ru - contributed by yalov
    - closes #58 - update ru.cfg localization- contributed by yalov
    - updates #33 - Localization project - contributed by zer0kerbal
- Bug
    - closes #24 - superklue docked docking ports while in flight - thank you to @robin Patenall
    - closes #54 - typo
    - closes #56 - seconds not localized
- *** Possible future changes ***
    - #39, #40, #41, #43, #44, #45, #46, #47, #48, #49, #50, #51 and #53 - more localizations
    - #25 - auto destruct during launch
    - #17, #18 - bigger boom, bigger badda-boom
    - #16 - boom stick
    - #1 - staging
@zer0Kerbal zer0Kerbal mentioned this issue Oct 26, 2021
Merged
Localization automation moved this from In progress to Done Oct 26, 2021
Kaboom! version 1.4.0.0 automation moved this from In progress to Done Oct 26, 2021
Bug Triage automation moved this from Low priority to Closed Oct 26, 2021
zer0Kerbal added a commit that referenced this issue Oct 26, 2021
@zer0Kerbal
Merge pull request #59 from zer0Kerbal/1.4.0.0-prerelease
1f24791 
# Version 1.4.0.0 - SuperKlue Implosions!!
- 25 Oct 2021  
- Kerbal Space Program [KSP 1.12.2]
### Added  

- added ![][ES] Spanish (Español) (thank you [Tacombel][LINK:tacombel])
- added ![][RU] Russian (Русский) (thank you [Forums: Flart][LINK:flart] - [Github: yalov][LINK:yalov])
- ***your translation here***

### `Code'

- thank you to ['@flart'][LINK:flart] aka [yalov][LINK:yalov]
- if glued kaboom is enabled and there was in-flight docking, docking ports kaboom together
- longer ScreenMessage
- remove unnecessary usings
- update .csproj

### Updated

- Documentation
  - readme
  - release notes
  - Attribution
  
### Status

- Features/Issues/Milestones
    - closes #20 - duplicate
    - closes #21 - duplicate
    - closes #22 - duplicate
    - closes #23 - Dev kaboom superglue [pull request] contributed by zer0Kerbal
    - closes #32 - Kaboom Safety Cover not localized
    - closes #35 - 1.3.99.2 beta 3 beta - contributed by zer0Kerbal
    - closes #36 - Create es-es.cfg - contributed by Tacombel
    - closes #37 - Localization - English (United States)] <en-us.cfg> - contributed by zer0Kerbal
    - closes #42 - Localization - Russian (Русский) <ru.cfg> - contributed by yalov
    - closes #52 - Localization - Spanish (Español) <es-es.cfg> - contributed by Tacombel
    - closes #57 - localization fixes + ru - contributed by yalov
    - closes #58 - update ru.cfg localization- contributed by yalov
    - updates #33 - Localization project - contributed by zer0kerbal
- Bug
    - closes #24 - superklue docked docking ports while in flight - thank you to @robin Patenall
    - closes #54 - typo
    - closes #56 - seconds not localized
- *** Possible future changes ***
    - #39, #40, #41, #43, #44, #45, #46, #47, #48, #49, #50, #51 and #53 - more localizations 
    - #25 - auto destruct during launch
    - #17, #18 - bigger boom, bigger badda-boom
    - #16 - boom stick
    - #1 - staging

[RU]: https://raw.githubusercontent.com/zer0Kerbal/zer0Kerbal/zed'K/Localization/img/Russian-flag-sm.png "Русский" 
[ES]: https://raw.githubusercontent.com/zer0Kerbal/zer0Kerbal/zed'K/Localization/img/Spanish-flag-sm.png "Español" 
[EN]: https://raw.githubusercontent.com/zer0Kerbal/zer0Kerbal/zed'K/Localization/img/American-flag-sm.png "American English" 
[LINK:russnash37]: https://forum.kerbalspaceprogram.com/index.php?/profile/77512-russnash37/ "Forums: RussNash37"  
[LINK:russnash]: https://github.com/russnash "GitHub: russnash"  
[LINK:tacombel]: https://github.com/Tacombel "Tacombel"  
[LINK:flart]: https://forum.kerbalspaceprogram.com/index.php?/profile/181486-flart/ "Flart"  
[LINK:yalov]: https://github.com/yalov "yalov"  
[LINK:zer0Kerbal]: https://forum.kerbalspaceprogram.com/index.php?/profile/190933-zer0kerbal/ "zer0Kerbal"
@zer0Kerbal zer0Kerbal removed this from Done in Localization Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zer0Kerbal zer0Kerbal

Labels
None yet
Projects
No open projects
Bug Triage
  
Closed
Kaboom! version 1.4.0.0
  
Done
Milestone
Localization - Master
Development

Successfully merging a pull request may close this issue.

Version 1.4.0.0 - SuperKlue Implosions!! zer0Kerbal/Kaboom
2 participants
@Tacombel @zer0Kerbal