Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nullref #75

Merged
merged 1 commit into from
Mar 24, 2022
Merged

fix nullref #75

merged 1 commit into from
Mar 24, 2022

Conversation

yalov
Copy link

@yalov yalov commented Mar 23, 2022 •
edited
Loading

fixes #74

@zer0Kerbal zer0Kerbal self-assigned this Mar 24, 2022
zer0Kerbal
zer0Kerbal approved these changes Mar 24, 2022
View reviewed changes
Copy link
Owner

@zer0Kerbal zer0Kerbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤗

@zer0Kerbal zer0Kerbal changed the base branch from master to 1.4.10.0-prerelease March 24, 2022 05:09
@zer0Kerbal zer0Kerbal added issue: code issue type type: fix Iterations on existing features or infrastructure. type: pull request upstream or side stream state: approved Approved to proceed. labels Mar 24, 2022
@zer0Kerbal zer0Kerbal merged commit 0663b28 into zer0Kerbal:1.4.10.0-prerelease Mar 24, 2022
zer0Kerbal added a commit that referenced this pull request Mar 25, 2022
@zer0Kerbal
Version 1.4.1.0 - <Missing Booms?>
d49276e 
### fix nullref

* thank you @yalov
* closes #74 - [Bug 🐞]: No Booms :( 🧯
* closes #72 - Missing #BOOM-KaboomAction = Kaboom! localization string

### Repo refresh

* Update all support files
* Add GitHub pages support

### Localization

* Add strings for [InstallChecker.cs]
* [#BOOM-IC-01] = Incorrect <<1>> v<<2>> installation.\n<<1>> has been installed incorrectly and will not function properly. All files should be located in KSP/GameData/<<3>>. Do not move any files from inside that folder.\n\nIncorrect path(s):\n<<4>>

### Code

* Update
  * [Version.tt] v2.0.2.1
  * [InstallChecker.cs] v2.1.0.0

### docs/

* Create
  * docs/
    * [404.md]
    * [Attributions.md]
    * [ManualInstallation.md]
    * [LegalMumboJumbo.md]
    * [Localizations.md]
    * Code/
      * [Kaboom.xml]
    * LegalMumboJumbo/
      * [FORUM-01.png]
      * [FORUM-02.png]
      * [FORUM-03.png]
      * [License.md]
    * ReleaseNotes/
      * [1.2.0.0.md]
      * [1.2.1.0.md]
      * [1.3.0.0.md]
      * [1.3.99.0.md]
      * [1.3.99.1.htm]
      * [1.3.99.2.htm]
      * [1.3.99.2-beta-3.md]
      * [1.4.0.0.md]
      * [1.4.0.1.md]
      * [1.4.1.0.md]

### Documentation

* Updated
  * [readme.md] v1.6.6.0
  * converted [changelog.cfg] to [changelog.md]
  * _releasenotes v1.3.1.1
  * [Kaboom.version]
    * update minimum KSP version
  * [_release.json] to schema v1.0.3.0

### Status

* Issues
  * closes #78 - 1.4.10.0 Social Media
  * closes #77 - 1.4.10.0 Update Documentation
  * closes #76 - 1.4.10.0 Verify Legal Mumbo Jumbo
  * closes #73 - Kaboom Version 1.4.10.0-prerelease - <Missing Booms?>
* Bugs
  * closes #71 - add missed #BOOM-KaboomAction - contributed by yalov
  * closes #72 - Missing #BOOM-KaboomAction = Kaboom! localization string
  * closes #74 - [Bug 🐞]: No Booms :( 🧯
  * closes #75 - fix nullref - contributed by yalov
@zer0Kerbal zer0Kerbal mentioned this pull request Mar 25, 2022
Merged
zer0Kerbal added a commit that referenced this pull request Mar 25, 2022
@zer0Kerbal
Merge pull request #79 from zer0Kerbal/1.4.1.0-prerelease
dc5ded2 
## Version 1.4.1.0 - `<Missing Booms?>`

* 23 Mar 2022
* for KSP 1.12.3

### fix nullref

* thank you @yalov
* closes #74 - [Bug 🐞]: No Booms :( 🧯
* closes #72 - Missing #BOOM-KaboomAction = Kaboom! localization string

### Repo refresh

* Update all support files
* Add GitHub pages support

### Localization

* Add strings for [InstallChecker.cs]
* [#BOOM-IC-01] = Incorrect <<1>> v<<2>> installation.\n<<1>> has been installed incorrectly and will not function properly. All files should be located in KSP/GameData/<<3>>. Do not move any files from inside that folder.\n\nIncorrect path(s):\n<<4>>

### Code

* Update
  * [Version.tt] v2.0.2.1
  * [InstallChecker.cs] v2.1.0.0
  * [AssemblyInfo.cs

### docs/

* Create
  * docs/
    * [404.md]
    * [Attributions.md]
    * [ManualInstallation.md]
    * [LegalMumboJumbo.md]
    * [Localizations.md]
    * Code/
      * [Kaboom.xml]
    * LegalMumboJumbo/
      * [FORUM-01.png]
      * [FORUM-02.png]
      * [FORUM-03.png]
      * [License.md]
    * ReleaseNotes/
      * [1.2.0.0.md]
      * [1.2.1.0.md]
      * [1.3.0.0.md]
      * [1.3.99.0.md]
      * [1.3.99.1.htm]
      * [1.3.99.2.htm]
      * [1.3.99.2-beta-3.md]
      * [1.4.0.0.md]
      * [1.4.0.1.md]
      * [1.4.1.0.md]

### Documentation

* Updated
  * [readme.md] v1.6.6.0
  * converted [changelog.cfg] to [changelog.md]
  * _releasenotes v1.3.1.1
  * [Kaboom.version]
    * update minimum KSP version
  * [_release.json] to schema v1.0.3.0

### Status

* Issues
  * closes #78 - 1.4.10.0 Social Media
  * closes #77 - 1.4.10.0 Update Documentation
  * closes #76 - 1.4.10.0 Verify Legal Mumbo Jumbo
  * closes #73 - Kaboom Version 1.4.10.0-prerelease - <Missing Booms?>
* Bugs
  * closes #71 - add missed #BOOM-KaboomAction - contributed by yalov
  * closes #72 - Missing #BOOM-KaboomAction = Kaboom! localization string
  * closes #74 - [Bug 🐞]: No Booms :( 🧯
  * closes #75 - fix nullref - contributed by yalov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zer0Kerbal zer0Kerbal zer0Kerbal approved these changes

Assignees

@zer0Kerbal zer0Kerbal

Labels
issue: code issue type state: approved Approved to proceed. type: fix Iterations on existing features or infrastructure. type: pull request upstream or side stream
Projects
None yet
Milestone
1.4.1.0-prerelease <Missing Booms?>
Development

Successfully merging this pull request may close these issues.

[Bug 🐞]: No Booms :( 🧯
2 participants
@yalov @zer0Kerbal