Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar in docs #35

Merged
merged 1 commit into from
Apr 16, 2018
Merged

Grammar in docs #35

merged 1 commit into from
Apr 16, 2018

Conversation

jdevera
Copy link
Contributor

@jdevera jdevera commented Apr 13, 2018

I have gone through most of the English text outside code and fixed typoes, grammar, etc. I have also adapted some expressions in the hopes to make them more correct or clear.

My base is the develop branch.

@jdevera jdevera changed the base branch from master to develop April 13, 2018 13:53
@jdevera
Copy link
Contributor Author

jdevera commented Apr 13, 2018

Ok, I see the tests also contain the strings, I'll try to locate them later.

@zerasul zerasul added the good first issue Good for newcomers label Apr 13, 2018
@zerasul
Copy link
Owner

zerasul commented Apr 13, 2018

Hi, thanks for your pull request. Im going to merge it when the tests pass successfully.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 90

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.351%

Totals Coverage Status
Change from base Build 78: 0.0%
Covered Lines: 169
Relevant Lines: 185

💛 - Coveralls

@zerasul
Copy link
Owner

zerasul commented Apr 16, 2018

Thanks for the Pull Request i will merge it now.

@zerasul zerasul merged commit fedf90c into zerasul:develop Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants