Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Add different networks. #35

Conversation

rockfridrich
Copy link
Member

Add different networks as a wrappers for SimpleNetwork, fix tests and add testing address for tests
Closes #9

@0crat
Copy link

0crat commented Feb 19, 2018

@Biboran/z please, pay attention to this pull request

@0crat 0crat added the scope label Feb 19, 2018
@0crat
Copy link

0crat commented Feb 19, 2018

Job #35 is now in scope, role is REV

@rockfridrich
Copy link
Member Author

@Biboran should we place available methods validation to Network object?
For example, parity_nextNonce can be called only with ParityNework.
Also there could be different responses based on network you are using

Copy link
Contributor

@abdulowork abdulowork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InfuraChain seems like a pure DTO to me. It doesn't serve a good purpose and violates encapsulation by exposing isTest flag which is a bad idea. If something is intended for testing it should fit into interface polymorphically without need to expose such flags.

Could you please outline what problem is it supposed to solve? We can think on a better design together.

@abdulowork
Copy link
Contributor

@rockfridrich let's forgo Parity in this PR. Could you please create a separate issue and promptly describe how working with Parity would be different from working with Geth.

@abdulowork abdulowork merged commit 8073a9c into zeriontech:develop Feb 20, 2018
@0crat
Copy link

0crat commented Feb 20, 2018

The job #35 is now out of scope

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing MainnetInfuraNetwork
3 participants