Fix FTP mode #2
Closed
Fix FTP mode #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know why, but removing this line makes FTP mode work.
|
You have introduced a bug. You are not reading the file write mode from the request therefore always using direct file writes. So, this doesn't really fix anything, it merely makes it impossible to select FTP or Hybrid mode. |
|
Sorry, yes, Nik is right. Does not use ftp mode with my fix. |
zero-24
pushed a commit
that referenced
this pull request
Apr 12, 2016
zero-24
pushed a commit
that referenced
this pull request
Jul 20, 2016
* bootstrap option * valid html &-> & * Fix no-user button * for no-user the value was null
zero-24
pushed a commit
that referenced
this pull request
Aug 26, 2016
…nu item edit form, for item that belongs to large menu) (joomla#11628) * Remove unused left join in getOptions for menuparent form element * Replaced unneeded group by with distinct * fix joomla#11628 for postgresql (#2) in postgresql don't work as it is now , it give an **SQL ERROR** for the `ORDER BY` clause field used `a.lft` must be in the select list of fields when the `SELECT` use `DISTINCT()`
zero-24
pushed a commit
that referenced
this pull request
Oct 25, 2016
… (joomla#12291) * Cleanups, fixes and a bit of optimizations for site/components batch #2 - com_contact Note: This is a single commit bundling all types of changes, since PR joomla#12261 which had detailed commits, was rejected as a whole * oops ;)
zero-24
pushed a commit
that referenced
this pull request
Jan 1, 2017
* Some improvements in tests #2: - fix callable name mismatches - removed closing tags (also one that's in other PR, to not clash) - removed loop that does nothing * Revert removal of empty loop, as $i is decremented in the while statement
zero-24
pushed a commit
that referenced
this pull request
Jan 17, 2017
* Added client id column to menu_type table. Allow creating and editing of "menutype" records with client_id = 1 Add client_id filters in menu and menu items list views Sync menu type filter and client_id filter allowing only menu type in the URL query parameter (B/C) Both Lists now also filtered by client id. Client id selection updates the menu type list options to show choices only for that client id TBD: Reserved menu types: main & menu * In modal list view we currently hide client_id filter and show only site menu types, will be updated once we have more clear vision. Menu type assignment to backend mod_menu config from both menu manager and module manager. Though that is not functional within the module itself. * Add/edit menu item redirect with clientId from list filter. Load menu item form based on active client id Menu type dropdown choices limited to active client id value Show menu-item-type choices (modal) trigger with client id parameter in the url Switch edit layout based on client id * Menu item type loading from component metadata xml or mvc not identifies backend and frontend application separately. Not yet able to load menu item type from backend so returns empty list. Front-end is still intact and unaffected. * Edit menu item and create menu item set to follow client id and menu type value consistenty. When creating menu item alias, the referenced menu must also belong to same client id. Client id field removed from form, this should be auto-calculated from the menu type when saving. * Adding layout metadata xml in backend to reference menu item types as it was in front-end. Removed unnecessary admin specific layout added earlier as it is so far same as original edit.php, may be added back when needed. Remove page specific meta data fields from backend component type menu items. For now disable/unsupport association for backend menu items. Disallow change of client id for existing menu items, unexpected conflicts may occur if allowed so better be safe. Ref to #2 * Created each backend menu items using menu manager as a replica of existing Joomla backend menu. These are to be used for testing during upgrading menu module. language keys are not yet translated. Translation will be done as we are ready with most new or modified language keys application wide. Backend menu items does not require all those parameters as that with front-end menu items. Therefore segregated entire menu item xml for backend/frontend. Ref #2 * [a11y] Protostar back to top (joomla#12446) * [a11y] Protostar - back to top link * Oops Andre was right * add anchor for non-js enabled browsers * Restructure mod_menu to load preset menu items as an option (default). Other options will be the menu-type and will cause us to load from database. Ref #2 * Disallow editing and set to home of protected menu type menu items viz. 'main' and 'menu' Allow explicit filtering by protected menu type choices in menu items list view. Not limited to #__menutypes table entries only. Unfiltered list still excludes those menu items. (B/C ok) Menu items created during installation of a component are now saved as published. When unpublished we won't load it in customised menu's component menu container. They will still be loaded irrespective of state as previously when preset is in use. (B/C ok) Home page can now be set one per client instead of one overall. Menu module only loads item from 'main' and 'menu' type menu items when requested for component menu items. This filter is now required because we are now going to have other custom menu types for backend which should not be included. Ref #2 * Load menu items from databases in correct hierarchy. Remove any extra separator type menu items created due to exclusion of certain menu items based on various conditions. Populate menu items loaded from db into the AdminCssMenu object for final rendering. Load new installed components menu items dynamically under the specified menu item with “components container” flag. Any unpublished menu items from the protected menutypes (viz. “main” and “menu”) will be skipped. When loading from system preset menu items, these components menu items are all included regardless of their published state. (B/C ok). Ref #2 * View manifests for menu item type and related language key updates. ref #2 * Minor mistake fix. * Translate menu item titles in list view. Ref #2 * Reset the preset menu structure to be same as the current J37 branch state, dropping implicit inclusion of joomla#10657 improvement. Ref #2 * Allow the existing components to leverage the menu/submenu entries in their install manifest for admin menu manager menu link types. This provides ability to create links for then without requiring them to add layout manifests. Hence, full B/C solution. Ref #2 * Minor fix * Remove temporary dev phase files * Preparing for PR, database and install script updates. Ref #2 * Minor fix * Codestyle fix * CS fix * Don’t sort menu items * Sort lang keys Allow ‘component’ as first level alias in admin menu items Fix lang key Remove ‘home’ setting from admin menu items * apply in hathor * menu item alias check for site only * Post merge fixes. * Fixes as suggested by @infograf768 1. Group menu types by client id in lists and default admin menu 2. Hide association tab for admin menu items. 3. Hide client id filter for association mapping modal. * Add recovery mode for menu where the selected admin menu does not contain link to module manager and/or menu manager. * minor bug fix * Remove assoc column for admin menu items. Make recovery mode message more straight forward. Change radio to toggle buttons.
zero-24
pushed a commit
that referenced
this pull request
Jan 23, 2017
* tinymce 4.5.2 Version 4.5.2 - January 4, 2017 * Clean up JModelForm * xml update version * Catch "expects parameter 2 to be string" error * Remove multiple parameter from user field * Remove default value from the field params to inherit from plugin * It's 2017. Happy New Year * Some improvements in tests #3: (joomla#13402) * Some improvements in tests #3: - call static methods correctly * Fix T_PAAMAYIM_NEKUDOTAYIM (for all PHP 5.x) * Remove forgotten call * Changed a few things after conversation with @mbabker * Fixes according to @andrepereiradasilva's comments * Unnecessary double quotes in /libraries/joomla (joomla#13372) * Replace unnecessary double quotes in /libraries/joomla * Formatting * CS Fix * Fixes, based on @andrepereiradasilva's comments. * Change remove string concatenations for some occurrences. * Fixes, based on @andrepereiradasilva's comments. * Fixes, based on @andrepereiradasilva's comments. * Fixes, based on @andrepereiradasilva's comments. * Fixing search for MySQL (joomla#13571) * Use $query->castAsChar instead of casting to integer * Codestyle * Clean up old code in cache.php file (joomla#12183) * Clean up in cache - part 1 * Remove old php4 style to catch exception which currently is useless. * Add shorten version of ternary pperators. * Add fix for contains() * Add more email cloaking unit tests and fix email cloaking bug (joomla#13446) * Rsponsive article edit fields (joomla#13586) * Fix BS grid (joomla#13560) * Fixing Showon in plugins/modules/templates (joomla#13549) * Adding field group to JFormHelper::parseShowOnConditions and rearranged argument order. * codestyle * $field->assigned_cat_ids may not exist. (joomla#13570) * Clean up ModulesModelModule class (joomla#13380) * Make the calendar work in the subform field (joomla#13153) * [com_fields] Add Joomla loading overlay when form submit is triggered by category selector change (joomla#13320) * Added overlay box and message box for submit and reload form after category change * Removed commented testing code * Added language strings * CS fix, added missing spaces * Used Joomla logo spinner instead of fixed message * Reverted changes in admin lang file * CS * Revert frontend lang changes * Added Joomla loading overlay to new field form when changing field type * Added Joomla.loadingLayer show to typeHasChanged JS method too * PostgreSQL - return the same string each time of call __toString() on update query (joomla#13284) * TranslateFormat in all other forms (joomla#13158) * TranslateFormat in all other forms * Revert for tracks filter bar * Fix for issue joomla#13531 (joomla#13535) * Fix for issue joomla#13531 - [AND] and [OR] operators were not functioning correctly. Fixed. - some cleanup of whitespaces in XML file and removal of rulers when the encapsulated fields are not showing. * Removed $key, as it was an unused leftover * CS Fix * Whitespace Fix * Whitespace Fix * Whitespace Fix#2 * Conflict resolution (hopefully, Don't have a complete dev-environment right now.) * Added css classes to the mod_login submit buttons (joomla#13379) * Added css classes to the mod_login submit buttons * Added css classes to the mod_login submit buttons * Changed class to login-button in both modules * PHPMailer update (joomla#13575) * Correcting sidebar display LTR and RTL (replaces joomla#13548) (joomla#13593) * Fix for Issue joomla#13588 - mod_articles_categories - Fatal error: Class 'ContentHelperRoute' not found... (joomla#13590) * Update helper.php Remove JLoader::register('ContentHelperRoute', JPATH_SITE . '/components/com_content/helpers/route.php'); * Update mod_articles_categories.php * Make clear Exception messages in JTable (joomla#13603) * Fix issue where fields is false (joomla#13574) * Update jQuery Autocomplete to 1.2.27 (joomla#13282) * Show text "No Information Entered" in users profile when no value is set (joomla#13589) * Delete UCM content entries when Joomla articles are deleted (joomla#13592) * [com_fields] Add base list plugin class which activates the list plugin (joomla#13546) * Add base list plugin class * Update fieldslistplugin.php * Fixes joomla#13177: Added where clause with block status (joomla#13545) * Menu manager for Joomla Backend Menu (joomla#13036) * Added client id column to menu_type table. Allow creating and editing of "menutype" records with client_id = 1 Add client_id filters in menu and menu items list views Sync menu type filter and client_id filter allowing only menu type in the URL query parameter (B/C) Both Lists now also filtered by client id. Client id selection updates the menu type list options to show choices only for that client id TBD: Reserved menu types: main & menu * In modal list view we currently hide client_id filter and show only site menu types, will be updated once we have more clear vision. Menu type assignment to backend mod_menu config from both menu manager and module manager. Though that is not functional within the module itself. * Add/edit menu item redirect with clientId from list filter. Load menu item form based on active client id Menu type dropdown choices limited to active client id value Show menu-item-type choices (modal) trigger with client id parameter in the url Switch edit layout based on client id * Menu item type loading from component metadata xml or mvc not identifies backend and frontend application separately. Not yet able to load menu item type from backend so returns empty list. Front-end is still intact and unaffected. * Edit menu item and create menu item set to follow client id and menu type value consistenty. When creating menu item alias, the referenced menu must also belong to same client id. Client id field removed from form, this should be auto-calculated from the menu type when saving. * Adding layout metadata xml in backend to reference menu item types as it was in front-end. Removed unnecessary admin specific layout added earlier as it is so far same as original edit.php, may be added back when needed. Remove page specific meta data fields from backend component type menu items. For now disable/unsupport association for backend menu items. Disallow change of client id for existing menu items, unexpected conflicts may occur if allowed so better be safe. Ref to #2 * Created each backend menu items using menu manager as a replica of existing Joomla backend menu. These are to be used for testing during upgrading menu module. language keys are not yet translated. Translation will be done as we are ready with most new or modified language keys application wide. Backend menu items does not require all those parameters as that with front-end menu items. Therefore segregated entire menu item xml for backend/frontend. Ref #2 * [a11y] Protostar back to top (joomla#12446) * [a11y] Protostar - back to top link * Oops Andre was right * add anchor for non-js enabled browsers * Restructure mod_menu to load preset menu items as an option (default). Other options will be the menu-type and will cause us to load from database. Ref #2 * Disallow editing and set to home of protected menu type menu items viz. 'main' and 'menu' Allow explicit filtering by protected menu type choices in menu items list view. Not limited to #__menutypes table entries only. Unfiltered list still excludes those menu items. (B/C ok) Menu items created during installation of a component are now saved as published. When unpublished we won't load it in customised menu's component menu container. They will still be loaded irrespective of state as previously when preset is in use. (B/C ok) Home page can now be set one per client instead of one overall. Menu module only loads item from 'main' and 'menu' type menu items when requested for component menu items. This filter is now required because we are now going to have other custom menu types for backend which should not be included. Ref #2 * Load menu items from databases in correct hierarchy. Remove any extra separator type menu items created due to exclusion of certain menu items based on various conditions. Populate menu items loaded from db into the AdminCssMenu object for final rendering. Load new installed components menu items dynamically under the specified menu item with “components container” flag. Any unpublished menu items from the protected menutypes (viz. “main” and “menu”) will be skipped. When loading from system preset menu items, these components menu items are all included regardless of their published state. (B/C ok). Ref #2 * View manifests for menu item type and related language key updates. ref #2 * Minor mistake fix. * Translate menu item titles in list view. Ref #2 * Reset the preset menu structure to be same as the current J37 branch state, dropping implicit inclusion of joomla#10657 improvement. Ref #2 * Allow the existing components to leverage the menu/submenu entries in their install manifest for admin menu manager menu link types. This provides ability to create links for then without requiring them to add layout manifests. Hence, full B/C solution. Ref #2 * Minor fix * Remove temporary dev phase files * Preparing for PR, database and install script updates. Ref #2 * Minor fix * Codestyle fix * CS fix * Don’t sort menu items * Sort lang keys Allow ‘component’ as first level alias in admin menu items Fix lang key Remove ‘home’ setting from admin menu items * apply in hathor * menu item alias check for site only * Post merge fixes. * Fixes as suggested by @infograf768 1. Group menu types by client id in lists and default admin menu 2. Hide association tab for admin menu items. 3. Hide client id filter for association mapping modal. * Add recovery mode for menu where the selected admin menu does not contain link to module manager and/or menu manager. * minor bug fix * Remove assoc column for admin menu items. Make recovery mode message more straight forward. Change radio to toggle buttons. * Add SMS to External URL menu item type (joomla#13615) Allows data like sms://+15555555555 to be used instead of getting "Save Not Permitted" * Adding the Multilanguage Associations Manager (joomla#13537) * Merge Associations rewrite * updated searchtool with the new way * udpated edit view title * added contact associationshelper class * temp fix * fix for category filter * added newsfeeds associations helper * CAPS for params * lang tag and added a helper function * added land tags * code style fix * better title in associations view * better title * use the usual naming * fix language tag, thanks to brian teeman and twitter :-) * initial review * on simple change * on simple change 2 * simple * some more helper changes * Update associations.php * Update associations.php * app isn’t set a model property * correct return value * simplify code adn use helper method * use typename directly * changed the tooltip position * Correct menu helper * remove unreacable code * correcting checked_out * com_menus * fixed not supportted message * installation * fix menu install * Spaces -> tabs * [com_associations] - mssql updates (joomla#13617) the missed mssql updates for joomla#13537 * [com_fields] Improved description in the "description" tooltip Fixes joomla#13392 (joomla#13557) * Fixes joomla#13195: Added margin bottom to sidebar menu * Fixes joomla#13392: Changed description field tooltip * Fixes joomla#13392: Changed description field tooltip * Fixes joomla#13392: Changed description field tooltip * sync admin menu menutype (joomla#13618) * Routing: Remove IDs from tags URLs, use menu item of tags view as default for tag view (joomla#11166) * Remove id from tags, use tags list menu item as default for tag * Code style, remove useless code, feature: first Itemid for tags view, second Itemid for default tag view * Updating install.xml en-GB administrator (joomla#13623) * run grunt
zero-24
pushed a commit
that referenced
this pull request
Mar 11, 2017
* Add a fieldset in the component config to support disabling the debug users and groups view. The defaullt is to on * Add code to read the params from the config.xml If not set then it defaults to ON Change the IF statement use to turn on the display of the debug link to use the param instead of the JDEBUG * Add code to read the params from the config.xml If not set then it defaults to ON * Change the IF statement use to turn on the display of the debug link to use the param instead of the JDEBUG * fix the params IF statement * Fix the params fallback * Add language strings * Add missing Cancel button from toolbar (replaces PR14384) Add missing Options button from toolbar * Simplify param check * Simplify param check #2 * change the strings from debug to advanced * fix toolbar permissions check * Update config.xml * Update default.php * Update default.php
zero-24
pushed a commit
that referenced
this pull request
May 31, 2017
* Type safe string comparison of strings in plugins - second iteration - some more string comparisons - some bool - some int * Fixed two bugs introduced in previous commit (one involving multiple comparisons) * Missed a comparison. Thanks @shur! * Reversed type safe comparison, as it turns out, that the type of the value is not guaranteed. * Reversed type safe comparison (#2), as it turns out, that the type of the value is not guaranteed. * Reverted this one to not clash with @laoneo's refactoring efforts
zero-24
pushed a commit
that referenced
this pull request
Aug 27, 2018
zero-24
pushed a commit
that referenced
this pull request
Sep 16, 2018
* Load correct core files of override files (#2) Start implements loadcorefile() in administrator/components/com_templates/Model/TemplateModel.php * CS (#3) Coding Standards * codingstandards * codingstandards (#4) * Test (#6) Phase 2 (2 part) Mechanism to find correct core file and implementation. * Remove Notice: Only available for html-folder * Remove Warning if core file not found (#11) Thanks. So one part of the issue joomla-projects/gsoc18_override_management#12 is done. * Implement the diff view in template manager Implement the diff view in template manager * coding standard (#17) * fix diff (#18) Fix bug in path in case of administrator template override. Fix bug in path in case of administrator template override. * Notification after update and TEST (#16) Find changed files of overridden files and show message. * coding standard (#21) * correction * correction (#26) * Correcthtmlpath (#27) * correction * change oldhtml to newhtml * List of updated override files. (#30) * addcss (#34) * Final Product (#39) Core and Diff view Updated override history list. Quick icon notification plugin. Override control plugin. * save 3 lines :) * New feature show status. (#47) show status in com_template view templates * link * corrected namespace * Button to Switch (#35) * wip add Switcher * wip style switcher * wip style switch make inline and change on off text * wip start with js * wip js * wip delete buttons and make js more robust * wip save to storage * wip delete old code * wip * wip lint * wip css * set default value for switcher * wip make switcher blue * wip * wip * build * correct names * create new functions * fist test code * use onchange * undo installer.min.js * add forgotten new line at the end of css file * correct align * correct compare.es6 - only deleted the toggle part * correct compare.js - only deleted the toggle part * wip * reduce timeout * wrap in funcitons * wip * add use strict to both js-files(compare and toggle) * add the timeout value of 500 again, because 200 are not enought in my case * use css class 'active' for toggle views * add strict * time out for editor * wip * improvments use newActive and switch * correction * width of switcher-spans * correct align * do not use global * wip * removed timeouts * JTEXT to TEXT * forgotton last line * deleted duplicated comments * css fix align * use unnamed functions in es6 * Sql files for fix database (#50) * sql files for database fix * delete space * Suggestion for displaying Dates in view updates files (joomla#52) Correct Dates and do not use date of file any more * Store Date as UTC and show it in server time zone (joomla#57) * modified and created date are created and stored in UTC * convert dates for displaying in model * spar a loop * normalize timezone in view * use language constants for dateformat * JToolbarHelper to ToolbarHelper * CS * namespace * plural * name * clean * text * fx * sin * files * s * Suggestion for language strings (joomla#60) * language strings * correct typo * delete media folder plg_quickicon * add folder plg_quickicon to build/media_src * delete files in media folder * Move media folder - System (joomla#66) * multi * cs * delete files in media folder for joomla toolbar (joomla#67) * Fix button switchers style. (joomla#70) * button * CS * changed uitab.addTab for updated files * Bring back core.js changes. (joomla#69) * core.js * const * fix * form * core * hound * CS * scopr * grid * alpha * cs * lang * only override file * lang * override lang installer * Cs * sub * Update list of core extensions (joomla#71) * Language changes (joomla#76) * update * Update en-GB.com_templates.ini * override JLIB_HTML_PUBLISH_ITEM this is the hover text on the publish icon in the list of files * Change icon (joomla#74) change the icon to use an outline for more consistency * lang * not core (joomla#75) * not core * Update en-GB.plg_installer_override.ini * namespace * cs * Updated files (joomla#82) * Update default_updated_files.php * Update en-GB.com_templates.ini * Update en-GB.com_templates.ini (joomla#81) * Update en-GB.plg_quickicon_overridecheck.ini (joomla#80) * Update en-GB.plg_quickicon_overridecheck.ini (joomla#79) * remove space (joomla#78) * Update en-GB.plg_quickicon_overridecheck.ini * Update en-GB.plg_quickicon_overridecheck.sys.ini * remove hardcoded id * null get function * state * clean * More changes "core" to "original" (joomla#85) * cs * update * plural
zero-24
pushed a commit
that referenced
this pull request
Sep 23, 2018
* This is a combination of 8 commits. This is the 1st commit message: > First WIP version of supporting nested subforms. This is the commit message #2: > Fix nested subforms not getting correct name attribute on input fields. This is the commit message #3: > Fix subform rows having invalid index, fix small typo. This is the commit message #4: > Replace the unique subform id via random bytes by just an increasing integer in the fields type rendering process. This is the commit message #5: > Implement feedback from PR at Joomla; > - Use a <template> HTML element for the template of the subform rows, > not a url encoded string inside of a <script> element. > - Fix code style errors reported by phpcs. > - Make the fixing of the unique attributes (name, id, etc) of input elements > of nested subform rows more errorprone, using the same method as the main > subform row. > - Manually add a minified version of the javascript file. This is the commit message #6: > Fix failing javascript tests due to changed structure of subform repeatable template container. This is the commit message #7: > Change subform repeatable javascript test to correctly check on > 0-indexed rows, previously they have been 1-indexed. This is the commit message #8: > Fix a problem where multi-level subforms on the same level doesnt trigger their template correctly. > Additionally added a note why the fixScripts() method is broken and how it could get better. * Commit code styling errors and add an aria label for the outermost 'add' button. * Fix double group-add button on repeatable subform type.
zero-24
pushed a commit
that referenced
this pull request
Jan 27, 2022
…6787) * [3.10] [PHP 8.1] Mysqli database driver escapt function fix Fixes `Deprecated: mysqli_real_escape_string(): Passing null to parameter #2 ($string) of type string is deprecated in libraries/joomla/database/driver/mysqli.php on line 254` * Fix also the other db drivers Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
zero-24
pushed a commit
that referenced
this pull request
Mar 24, 2022
…ler-sql-improvements-mod-1 [CMS PR 36506] Branch update and merge conflicts resolution
zero-24
pushed a commit
that referenced
this pull request
Mar 5, 2024
* Updating Jooa11y with latest build of Sa11y * Allow users to pass in boolean props to jooa11y * Addressing a backward compatibility * Deprecate strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why, but removing this line makes FTP mode work.