Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ascii_art | merge text-to-ascii functionality #87

Closed
ndeoligence opened this issue Oct 31, 2020 · 0 comments · Fixed by #90
Closed

ascii_art | merge text-to-ascii functionality #87

ndeoligence opened this issue Oct 31, 2020 · 0 comments · Fixed by #90
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ndeoligence
Copy link
Contributor

The PR #84 added an option for the user to send their input text as a clarg instead of the prompt. This is cool. But we can merge the 2 options: --textinput & --text so that if an argument isn't given, the user gets prompted for text.

See https://click.palletsprojects.com/en/7.x/options/#prompting (2nd example)
@ndeoligence ndeoligence added enhancement New feature or request good first issue Good for newcomers labels Oct 31, 2020
szabopeter added a commit to szabopeter/ascii-art that referenced this issue Oct 31, 2020
@szabopeter
CLI: merge text and textinput commands
904230a 
Should fix zero-to-mastery#87
This branch is based on cli-subcommands (zero-to-masteryGH-89)
@szabopeter szabopeter mentioned this issue Oct 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CLI: merge text options szabopeter/ascii-art
1 participant
@ndeoligence