Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TypeScript sample typings #156

Merged
merged 2 commits into from Jul 27, 2019
Merged

Update TypeScript sample typings #156

merged 2 commits into from Jul 27, 2019

Conversation

@abliarsar
Copy link
Contributor

abliarsar commented Jul 22, 2019

fixes #155
Probably should be a breaking change, because sample now accepts types of source and clock instead of their values

@now

This comment has been minimized.

Copy link

now bot commented Jul 22, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://effector-git-fork-abliarsar-fix-155.zerobias.now.sh

Copy link
Owner

zerobias left a comment

Can make do this without breaking changes?

At the moment, method overloads are defined by explicit iterating through all the combinations, we can add a few more

@abliarsar

This comment has been minimized.

Copy link
Contributor Author

abliarsar commented Jul 24, 2019

@zerobias, can you review it again? It shouldn't be breaking now.

@zerobias

This comment has been minimized.

Copy link
Owner

zerobias commented Jul 27, 2019

Big thanks! That’s going to be a major improvement of sample user experience 👍👍

@zerobias zerobias merged commit 376e612 into zerobias:master Jul 27, 2019
3 checks passed
3 checks passed
WIP Ready for review
Details
now Deployment has completed
Details
semaphoreci The build passed on Semaphore.
Details
@zerobias zerobias mentioned this pull request Jul 27, 2019
@abliarsar abliarsar deleted the abliarsar:fix/155 branch Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.