Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent dictionary key being GC while unmarshal a value class #1220

Merged
merged 2 commits into from
Dec 28, 2020
Merged

Prevent dictionary key being GC while unmarshal a value class #1220

merged 2 commits into from
Dec 28, 2020

Conversation

pepone
Copy link
Member

@pepone pepone commented Dec 23, 2020

This PR fixes #1217

@pepone pepone added the ruby label Dec 23, 2020
@pepone pepone requested a review from bentoi December 23, 2020 09:23
@externl
Copy link
Member

externl commented Dec 23, 2020

Should be backport this fix to 3.6?

@pepone pepone merged commit 938d2e5 into zeroc-ice:3.7 Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@externl externl externl approved these changes

@bentoi bentoi bentoi approved these changes

Assignees
No one assigned
Labels
ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ruby Ice/objects macOS segfault
3 participants
@pepone @externl @bentoi