Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php: add return type declarations to __tostring #1411

Merged
merged 5 commits into from
Feb 8, 2023
Merged

php: add return type declarations to __tostring #1411

merged 5 commits into from
Feb 8, 2023

Conversation

externl
Copy link
Member

@externl externl commented Feb 6, 2023 •
edited
Loading

This is part of #1405

pepone
pepone reviewed Feb 6, 2023
View reviewed changes
cpp/src/slice2php/Main.cpp Outdated Show resolved Hide resolved
@externl @pepone
Update cpp/src/slice2php/Main.cpp
718c2c8 
Co-authored-by: Jose  <pepone@users.noreply.github.com>
@externl externl marked this pull request as ready for review February 7, 2023 13:50
@externl externl changed the title Add return type declarations to __tostring php: add return type declarations to __tostring Feb 7, 2023
@externl externl requested a review from pepone February 7, 2023 13:50
@pepone
Copy link
Member

pepone commented Feb 8, 2023

This change doesn't work with PHP 7.1, I get the following error with the Windows build

 C:\Users\jose\source\repos\3.7.9\1405-php-return-type-declaration\php\src\php\Config.h(127): warning C4003: not enough actual parameters for macro 'ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO' (compiling source file ..\Proxy.cpp) [C:\Users\jose\source\repos\3.7.9\1405-php-return-type-declaration\php\src\php\msbuild\php_ice.vcxproj]
         C:\Users\jose\source\repos\3.7.9\1405-php-return-type-declaration\php\src\php\Config.h(127): warning C4003: not enough actual parameters for macro 'ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO' (compiling source file ..\Endpoint.cpp) [C:\Users\jose\source\repos\3.7.9\1405-php-return-type-declaration\php\src\php\msbuild\php_ice.vcxpro
       j]
         C:\Users\jose\source\repos\3.7.9\1405-php-return-type-declaration\php\src\php\Config.h(127): warning C4003: not enough actual parameters for macro 'ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO' (compiling source file ..\Connection.cpp) [C:\Users\jose\source\repos\3.7.9\1405-php-return-type-declaration\php\src\php\msbuild\php_ice.vcxp
       roj]
         C:\Users\jose\source\repos\3.7.9\1405-php-return-type-declaration\php\src\php\Config.h(127): warning C4003: not enough actual parameters for macro 'ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO' (compiling source file ..\Logger.cpp) [C:\Users\jose\source\repos\3.7.9\1405-php-return-type-declaration\php\src\php\msbuild\php_ice.vcxproj]
         C:\Users\jose\source\repos\3.7.9\1405-php-return-type-declaration\php\src\php\Config.h(127): warning C4003: not enough actual parameters for macro 'ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO' (compiling source file ..\Init.cpp) [C:\Users\jose\source\repos\3.7.9\1405-php-return-type-declaration\php\src\php\msbuild\php_ice.vcxproj]
         C:\Users\jose\source\repos\3.7.9\1405-php-return-type-declaration\php\src\php\Config.h(127): warning C4003: not enough actual parameters for macro 'ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO' (compiling source file ..\Operation.cpp) [C:\Users\jose\source\repos\3.7.9\1405-php-return-type-declaration\php\src\php\msbuild\php_ice.vcxpr
       oj]
         C:\Users\jose\source\repos\3.7.9\1405-php-return-type-declaration\php\src\php\Config.h(127): warning C4003: not enough actual parameters for macro 'ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO' (compiling source file ..\Communicator.cpp) [C:\Users\jose\source\repos\3.7.9\1405-php-return-type-declaration\php\src\php\msbuild\php_ice.vc
       xproj]
         C:\Users\jose\source\repos\3.7.9\1405-php-return-type-declaration\php\src\php\Config.h(127): warning C4003: not enough actual parameters for macro 'ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO' (compiling source file ..\Properties.cpp) [C:\Users\jose\source\repos\3.7.9\1405-php-return-type-declaration\php\src\php\msbuild\php_ice.vcxp
       roj]
         C:\Users\jose\source\repos\3.7.9\1405-php-return-type-declaration\php\src\php\Config.h(127): warning C4003: not enough actual parameters for macro 'ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO' (compiling source file ..\Types.cpp) [C:\Users\jose\source\repos\3.7.9\1405-php-return-type-declaration\php\src\php\msbuild\php_ice.vcxproj]
         C:\Users\jose\source\repos\3.7.9\1405-php-return-type-declaration\php\src\php\Config.h(127): warning C4003: not enough actual parameters for macro 'ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO' (compiling source file ..\Util.cpp) [C:\Users\jose\source\repos\3.7.9\1405-php-return-type-declaration\php\src\php\msbuild\php_ice.vcxproj]

pepone
pepone approved these changes Feb 8, 2023
View reviewed changes
cpp/src/slice2php/Main.cpp Outdated Show resolved Hide resolved
php/src/php/Config.h Outdated Show resolved Hide resolved
cpp/src/slice2php/Main.cpp Outdated Show resolved Hide resolved
externl and others added 3 commits February 8, 2023 09:45
@externl @pepone
Update cpp/src/slice2php/Main.cpp
3acc4e7 
Co-authored-by: Jose  <pepone@users.noreply.github.com>
@externl @pepone
Update php/src/php/Config.h
e5a6b66 
Co-authored-by: Jose  <pepone@users.noreply.github.com>
@externl
Review fixes
017f2de
@externl externl requested a review from pepone February 8, 2023 14:48
@externl externl merged commit 5444f32 into zeroc-ice:3.7 Feb 8, 2023
@externl externl deleted the 1405-php-return-type-declaration branch November 20, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepone pepone Awaiting requested review from pepone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@externl @pepone