slice2java: fix constructor parameter count check #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
externl
changed the title
pepone
approved these changes
Oct 9, 2023
Co-authored-by: Jose <pepone@users.noreply.github.com>
Co-authored-by: Jose <pepone@users.noreply.github.com>
bernardnormier
changed the title
Co-authored-by: Austin Henriksen <austin.r.henriksen79@gmail.com>
Co-authored-by: Austin Henriksen <austin.r.henriksen79@gmail.com>
|
I reworked the logic a bit. The new method now returns a bool indicating if the length is ok. I also found a few other places that needed fixing. I think this is cleaner than having lots of magic numbers (254, 255) scattered throughout the code. |
pepone
approved these changes
Oct 9, 2023
bernardnormier
approved these changes
Oct 9, 2023
InsertCreativityHere
approved these changes
Oct 9, 2023
Co-authored-by: Austin Henriksen <austin.r.henriksen79@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1539