Remove STRCAST macro #2450
Merged
Remove STRCAST macro #2450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
commented
Jul 11, 2024
| @@ -189,14 +147,6 @@ PyInit_IcePy(void) | |||
| Ice::registerIceDiscovery(false); | |||
| Ice::registerIceLocatorDiscovery(false); | |||
|
|
|||
| #if PY_VERSION_HEX < 0x03090000 | |||
There was a problem hiding this comment.
We required Python 3.12 with Ice 3.8
pepone
commented
Jul 11, 2024
| @@ -214,12 +213,7 @@ IcePy::getFunction() | |||
| // | |||
| // Get name of current function. | |||
| // | |||
| // Use PyEval_GetFrame with Python >= 3.11 | |||
| #if PY_VERSION_HEX >= 0x030B0000 | |||
There was a problem hiding this comment.
We require Python 3.12 with Ice 3.8.
bernardnormier
approved these changes
Jul 11, 2024
externl
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
STRCASTmacro. We have all const char strings wrapped with this macro that does aconst_cast, but seems it is not required with the currently supported platforms.