Update Glacier2 SessionControl::destroy impl to close the connection #2621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
commented
Aug 5, 2024
| @@ -52,14 +59,9 @@ SessionControlClient::run(int argc, char** argv) | |||
| { | |||
| test(false); | |||
| } | |||
| try | |||
| { | |||
| session->ice_ping(); | |||
There was a problem hiding this comment.
In this version of the test, it's the ping to an unknown session via Glacier2 that makes the router close the connection forcefully.
pepone
approved these changes
Aug 6, 2024
externl
approved these changes
Aug 6, 2024
bentoi
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want SessionControl::destroy to close the client->router connection, to allow the client to get notified as soon as the session is destroyed.
The client can then cleanup / establish a new session.