-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The sets of numbers in mathematics #31
Draft
TheRustifyer
wants to merge
47
commits into
main
Choose a base branch
from
numbers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code: added the imaginary and real part unicode symbol for the two different parts of a complex number code: added also the Euler's number like letter to the math symbols ci: now, the GH actions are executing the tests again for the project, since we are replacing the Catch2 suite with our own
… now includes the Naturals, the Integers and part of the Complex numbers
code: marking noexcept almost every function and constructor on the types
…eas determined for our codebase. The stylizer function has been refactored to be more memory efficient, saving a lot of potential std::string allocations on the concatenations
…ype satisfies the criteria to be a Number
…ype satisfies the criteria to be a Number code(numbers): implemented the basic operations for Rationals code(numbers): Implemented the implementation of the equality operators for Naturals, Integers and Rationals code(numbers): implemented some operator overloads for mix arithmetic operations between types
…ype satisfies the criteria to be a Number code(numbers): implemented the basic operations for Rationals code(numbers): Implemented the implementation of the equality operators for Naturals, Integers and Rationals code(numbers): implemented some operator overloads for mix arithmetic operations between types code(tsuite-assertions): cleaned the assertions module, and refactored the way of how are assertions handled internally code(zero::concepts): Created a set of concepts to constrain types that are printable
…string version of the picked variant
Note that a few modules has some troubles compiling: - There's issues on the legacy iterator module (pending to review, left commented now) - MSVC refuses to compile the `matrix.cppm` Matrix template type when we provide template arguments to the Row and Column Matrix template constructors - Tests are yet untested
…es to use Zork++ on the v0.10.0
…izer list braces nor std::vector, and other more for when there's no need for using a modifier
…th latest Clang changes on Zork++
…tch on Zork++ configuration file
TheRustifyer
force-pushed
the
numbers
branch
from
September 1, 2024 10:16
0a2d745
to
755487b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to bring types and operations that represents the most common set of numbers in mathematics, which are:
The idea is to provide strong types over the typical numerical datatypes that stores the underlying values, and also provide safe API's to work with them.
Also, ideally they will include operations to be able to work with them in set theory operations and other fields
To see the working implementation up until now, refer to the numbers_tests.cpp file under the zero/tests directory.