Replace ansii color codes with the formatter #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More colors have been added to the enum, as well as improved organization to make it easier to add more if needed in a structured way.
Add support for standard ANSI colors and extended 256-color palette in the stylize function. Implement logic to distinguish between standard ANSI color codes and extended color codes for precise text styling in terminal output. This enhancement allows for a broader range of color customizations, improving the readability and visual appeal of terminal text.
Replaced ANSII codes with our 'stylizer', and removed std::cout in favor of print and println.
TheRustifyer
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28
Text strings with ANSII code have been replaced by our
stylizerin the test suite.I also replaced the sstdout with our
print()andprintl()functions, which internally use theformatter.The colors we were using for the
stylizerwere a bit limited, and were not giving me the results I wanted (they were too bright).After some research, it was because they belonged to the extended palette of 256 colors (which I didn't know when I created the
stylizer).To solve it I slightly modified the
stylizerto recognize if it was a standard ANSII color or part of the extended palette, and in the process I added more colors and a better organization of them to make it easier to add more in the future if necessary.