Added azure keyvault functionality #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kautsig
reviewed
Apr 22, 2020
Nighthawk22
approved these changes
Apr 22, 2020
Co-Authored-By: Nighthawk22 <zollneritsch@gmail.com>
Closed
zerok
requested changes
Apr 22, 2020
zerok
approved these changes
Apr 27, 2020
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naming conventions problems:
vault-prefix,vault-mapping, should those be left as is? Since they now also apply to azure keyvault and the naming would be more clear if it was justprefixandmapping. But this would break backwards compatibility so maybe leave those two and addprefix,mappingas new arguments that do the same thing?azuresince i think it would be more confusing to name itkeyvaultbecause we already havevault. Again because of backwards compatibility don't think we should changevault.