Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: NewClientWithTarget miss default config #3358

Merged
merged 2 commits into from
Jun 16, 2023
Merged

fix: NewClientWithTarget miss default config #3358

merged 2 commits into from
Jun 16, 2023

Conversation

MarkJoyMa
Copy link
Collaborator

No description provided.

@MarkJoyMa MarkJoyMa requested a review from kevwan June 16, 2023 07:26
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #3358 (c2f6012) into master (71e8230) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted Files Coverage Δ
zrpc/client.go 94.00% <66.66%> (-6.00%) ⬇️

... and 1 file with indirect coverage changes

@kevwan kevwan merged commit 92f6c48 into zeromicro:master Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevwan kevwan kevwan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkJoyMa @kevwan