Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: logging sql read amplification #4049

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kevwan
Copy link
Contributor

@kevwan kevwan commented Apr 6, 2024

  1. logging concurrent same queries to let developers know where to prevent read amplification
  2. the solution is to use syncx.SingleFlight to prevent concurrent reading of the same results

@kevwan kevwan force-pushed the feat/sqlx-prevent-read-amplification branch from f9fae20 to 30ceed1 Compare April 6, 2024 12:02
Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.18%. Comparing base (8690859) to head (8c3843a).
Report is 10 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
core/stores/sqlx/readamplication.go 100.00% <100.00%> (ø)
core/stores/sqlx/stmt.go 100.00% <100.00%> (ø)

... and 254 files with indirect coverage changes

@kevwan kevwan changed the title feat: preventing sql read amplification by logging concurrent same queries feat: logging sql read amplification Apr 6, 2024
@kevwan kevwan added the area/orm Categorizes issue or PR as related to orm. label Apr 6, 2024
@kevwan kevwan force-pushed the feat/sqlx-prevent-read-amplification branch from 30ceed1 to 7ee82d6 Compare April 9, 2024 10:59
@kevwan kevwan force-pushed the feat/sqlx-prevent-read-amplification branch from 7ee82d6 to 8c3843a Compare April 10, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/orm Categorizes issue or PR as related to orm.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant