Various cleanups to zctx #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Asserts that zocket isn't null when destroying it; the tolerance for null sockets is a bogus workaround against corruption of zctx from unprotected use in multiple threads. * Renamed 'main' to 'shadow' to make more explicit (negative property names are not good). * Renamed 'socketsMutex' to 'mutex' since (a) camelCase breaks our style guidelines, and (b) we have one mutex to protect the object, there is no value in qualifying the name. * Cleaned up constructors, the code was messy. * All methods that modify or read zctx properties needed to be protected by the mutex, otherwise we'll get random outcomes. * I still do not like the multithreaded zctx; it is incompatible with the current code in zthreads (e.g. we don't need shadow contexts) and is not sufficiently tested IMO. Also, I still don't see a valid use case for it.
* Not tested on Windows. * Defines _CRT_SECURE_NO_DEPRECATE for all MSVC versions above 1500 * Previously was done only for version = 1500 * Usual warnings on new code (casts and signed comparisons), fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null sockets is a bogus workaround against corruption of zctx from
unprotected use in multiple threads.
names are not good).
guidelines, and (b) we have one mutex to protect the object, there is
no value in qualifying the name.
by the mutex, otherwise we'll get random outcomes.
current code in zthreads (e.g. we don't need shadow contexts) and is
not sufficiently tested IMO. Also, I still don't see a valid use case
for it.